Skip to content

Commit 78aa44f

Browse files
author
OpenShift Bot
authored
Merge pull request #14943 from bparees/sc_versioning
Merged by openshift-bot
2 parents 394f73e + a589ba8 commit 78aa44f

File tree

1 file changed

+6
-11
lines changed

1 file changed

+6
-11
lines changed

pkg/bootstrap/docker/openshift/helper.go

Lines changed: 6 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ import (
77
"net/http"
88
"os"
99
"path/filepath"
10+
"regexp"
1011
"strconv"
1112
"strings"
1213
"time"
@@ -669,19 +670,13 @@ func (h *Helper) ServerPrereleaseVersion() (semver.Version, error) {
669670
return semver.Version{}, fmt.Errorf("did not find version in command output")
670671
}
671672

672-
// The OSE version may have > 4 parts to the version string
673-
// We'll only take the first 3
674-
parts := strings.Split(versionStr, ".")
675-
if len(parts) > 3 {
676-
versionStr = strings.Join(parts[:3], ".")
677-
}
673+
// The OCP version may have > 4 parts to the version string,
674+
// e.g. 3.5.1.1-prerelease, whereas Origin will be 3.5.1-prerelease,
675+
// drop the 4th digit for OCP.
676+
re := regexp.MustCompile("([0-9]+).([0-9]+).([0-9]+).([0-9]+)(.*)")
677+
versionStr = re.ReplaceAllString(versionStr, "${1}.${2}.${3}${5}")
678678

679679
version, err := semver.Parse(versionStr)
680-
if err == nil {
681-
// ignore pre-release portion
682-
version.Pre = []semver.PRVersion{}
683-
h.version = &version
684-
}
685680
return version, err
686681
}
687682

0 commit comments

Comments
 (0)