treat fatal errors as actually fatal

Author: bparees

pkg/build/controller/config_controller.go

@@ -28,8 +28,12 @@ func (e ConfigControllerFatalError) Error() string {
 
 // IsFatal returns true if err is a fatal error
 func IsFatal(err error) bool {
-	_, isFatal := err.(ConfigControllerFatalError)
-	return isFatal
+	switch err.(type) {
+	case ConfigControllerFatalError, *ConfigControllerFatalError:
+		return true
+	default:
+		return false
+	}
 }
 
 type BuildConfigController struct {
@@ -73,7 +77,10 @@ func (c *BuildConfigController) HandleBuildConfig(bc *buildapi.BuildConfig) erro
 		if kerrors.IsConflict(err) {
 			instantiateErr = fmt.Errorf("unable to instantiate Build for BuildConfig %s/%s due to a conflicting update: %v", bc.Namespace, bc.Name, err)
 			utilruntime.HandleError(instantiateErr)
-		} else if buildgenerator.IsFatal(err) || kerrors.IsNotFound(err) || kerrors.IsBadRequest(err) {
+		} else if buildgenerator.IsFatal(err) || kerrors.IsNotFound(err) || kerrors.IsBadRequest(err) || kerrors.IsForbidden(err) {
+			instantiateErr = fmt.Errorf("gave up on Build for BuildConfig %s/%s due to fatal error: %v", bc.Namespace, bc.Name, err)
+			utilruntime.HandleError(instantiateErr)
+			c.Recorder.Event(bc, kapi.EventTypeWarning, "BuildConfigInstantiateFailed", instantiateErr.Error())
 			return &ConfigControllerFatalError{err.Error()}
 		} else {
 			instantiateErr = fmt.Errorf("error instantiating Build from BuildConfig %s/%s: %v", bc.Namespace, bc.Name, err)

pkg/build/controller/strategy/util.go

@@ -37,8 +37,12 @@ func (e FatalError) Error() string {
 
 // IsFatal returns true if the error is fatal
 func IsFatal(err error) bool {
-	_, isFatal := err.(FatalError)
-	return isFatal
+	switch err.(type) {
+	case FatalError, *FatalError:
+		return true
+	default:
+		return false
+	}
 }
 
 // setupDockerSocket configures the pod to support the host's Docker socket

pkg/build/generator/generator.go

@@ -38,8 +38,12 @@ func (e GeneratorFatalError) Error() string {
 
 // IsFatal returns true if err is a fatal error
 func IsFatal(err error) bool {
-	_, isFatal := err.(GeneratorFatalError)
-	return isFatal
+	switch err.(type) {
+	case GeneratorFatalError, *GeneratorFatalError:
+		return true
+	default:
+		return false
+	}
 }
 
 // BuildGenerator is a central place responsible for generating new Build objects