add warning on invalid --output-version

Author: juanvallejo

pkg/cmd/cli/cli.go

@@ -160,7 +160,7 @@ func NewCommandCLI(name, fullName string, in io.Reader, out, errout io.Writer) *
 				cmd.NewCmdApply(fullName, f, out),
 				cmd.NewCmdPatch(fullName, f, out),
 				cmd.NewCmdProcess(fullName, f, out),
-				cmd.NewCmdExport(fullName, f, in, out),
+				cmd.NewCmdExport(fullName, f, in, out, errout),
 				cmd.NewCmdExtract(fullName, f, in, out, errout),
 				observe.NewCmdObserve(fullName, f, out, errout),
 				policy.NewCmdPolicy(policy.PolicyRecommendedName, fullName+" "+policy.PolicyRecommendedName, f, out),

pkg/cmd/cli/cmd/export.go

@@ -47,7 +47,7 @@ to generate the API structure for a template to which you can add parameters and
   %[1]s export service -o json`
 )
 
-func NewCmdExport(fullName string, f *clientcmd.Factory, in io.Reader, out io.Writer) *cobra.Command {
+func NewCmdExport(fullName string, f *clientcmd.Factory, in io.Reader, out, errOut io.Writer) *cobra.Command {
 	exporter := &DefaultExporter{}
 	var filenames []string
 	cmd := &cobra.Command{
@@ -56,7 +56,7 @@ func NewCmdExport(fullName string, f *clientcmd.Factory, in io.Reader, out io.Wr
 		Long:    exportLong,
 		Example: fmt.Sprintf(exportExample, fullName),
 		Run: func(cmd *cobra.Command, args []string) {
-			err := RunExport(f, exporter, in, out, cmd, args, filenames)
+			err := RunExport(f, exporter, in, out, errOut, cmd, args, filenames)
 			if err == cmdutil.ErrExit {
 				os.Exit(1)
 			}
@@ -76,7 +76,7 @@ func NewCmdExport(fullName string, f *clientcmd.Factory, in io.Reader, out io.Wr
 	return cmd
 }
 
-func RunExport(f *clientcmd.Factory, exporter Exporter, in io.Reader, out io.Writer, cmd *cobra.Command, args []string, filenames []string) error {
+func RunExport(f *clientcmd.Factory, exporter Exporter, in io.Reader, out, errOut io.Writer, cmd *cobra.Command, args []string, filenames []string) error {
 	selector := kcmdutil.GetFlagString(cmd, "selector")
 	allNamespaces := kcmdutil.GetFlagBool(cmd, "all-namespaces")
 	exact := kcmdutil.GetFlagBool(cmd, "exact")
@@ -171,5 +171,18 @@ func RunExport(f *clientcmd.Factory, exporter Exporter, in io.Reader, out io.Wri
 	if err != nil {
 		return err
 	}
-	return p.PrintObj(result, out)
+	err = p.PrintObj(result, out)
+	if err != nil {
+		return err
+	}
+
+	// validSpecifiedVersion resolves to true if the version passed to this function matches the
+	// version assigned to the converted object
+	validSpecifiedVersion := (result.GetObjectKind().GroupVersionKind().Version == outputVersion.Version)
+	outputVersionString := kcmdutil.GetFlagString(cmd, "output-version")
+	if !validSpecifiedVersion && len(outputVersionString) > 0 {
+		err = fmt.Errorf("the output version specified (%v) is invalid, defaulting to %v\n", outputVersion, clientConfig.GroupVersion)
+	}
+
+	return err
 }