Extended test for registry garbage collector

Signed-off-by: Michal Minář <[email protected]>

Author: Michal Minář

test/extended/images/hardprune.go

@@ -0,0 +1,242 @@
+package images
+
+import (
+	"fmt"
+
+	g "github.com/onsi/ginkgo"
+	o "github.com/onsi/gomega"
+
+	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
+	kerrors "k8s.io/apimachinery/pkg/util/errors"
+	"k8s.io/apimachinery/pkg/util/sets"
+
+	"github.com/docker/distribution/digest"
+	"github.com/docker/distribution/manifest/schema2"
+
+	imageapi "github.com/openshift/origin/pkg/image/api"
+	registryutil "github.com/openshift/origin/test/extended/registry/util"
+	exutil "github.com/openshift/origin/test/extended/util"
+	testutil "github.com/openshift/origin/test/util"
+)
+
+type repoLink map[string][]string
+type expectedDeletions struct {
+	manifestLinks repoLink
+	layerLinks    repoLink
+	blobs         []string
+}
+
+var _ = g.Describe("[Feature:ImagePrune] Image hard prune", func() {
+	defer g.GinkgoRecover()
+	var oc = exutil.NewCLI("prune-images", exutil.KubeConfigPath())
+	var originalAcceptSchema2 *bool
+
+	g.JustBeforeEach(func() {
+		if originalAcceptSchema2 == nil {
+			accepts, err := registryutil.DoesRegistryAcceptSchema2(oc)
+			o.Expect(err).NotTo(o.HaveOccurred())
+			originalAcceptSchema2 = &accepts
+		}
+
+		readOnly := false
+		acceptSchema2 := true
+		err := registryutil.ConfigureRegistry(oc,
+			registryutil.RegistryConfiguration{
+				ReadOnly:      &readOnly,
+				AcceptSchema2: &acceptSchema2,
+			})
+		o.Expect(err).NotTo(o.HaveOccurred())
+
+		err = exutil.WaitForBuilderAccount(oc.KubeClient().Core().ServiceAccounts(oc.Namespace()))
+		o.Expect(err).NotTo(o.HaveOccurred())
+
+		g.By(fmt.Sprintf("give a user %s a right to prune images with %s role", oc.Username(), "system:image-pruner"))
+		err = oc.AsAdmin().WithoutNamespace().Run("adm").Args("policy", "add-cluster-role-to-user", "system:image-pruner", oc.Username()).Execute()
+		o.Expect(err).NotTo(o.HaveOccurred())
+	})
+
+	g.AfterEach(func() {
+		readOnly := false
+		err := registryutil.ConfigureRegistry(oc,
+			registryutil.RegistryConfiguration{
+				ReadOnly:      &readOnly,
+				AcceptSchema2: originalAcceptSchema2,
+			})
+		o.Expect(err).NotTo(o.HaveOccurred())
+	})
+
+	g.It("should prune orphaned blobs", func() {
+		oc.SetOutputDir(exutil.TestContext.OutputDir)
+		outSink := g.GinkgoWriter
+		registryURL, err := registryutil.GetDockerRegistryURL(oc)
+		o.Expect(err).NotTo(o.HaveOccurred())
+
+		cleanUp := cleanUpContainer{oc: oc}
+		defer cleanUp.run()
+
+		dClient, err := testutil.NewDockerClient()
+		o.Expect(err).NotTo(o.HaveOccurred())
+
+		_, err = RunHardPrune(oc)
+		o.Expect(err).NotTo(o.HaveOccurred())
+
+		baseImg1, imageId, err := BuildAndPushImageOfSizeWithDocker(oc, dClient, "A", "latest", testImageSize, 2, outSink, true, false)
+		o.Expect(err).NotTo(o.HaveOccurred())
+		cleanUp.addImage(baseImg1, imageId, "")
+		baseImg1Spec := fmt.Sprintf("%s/%s/A:latest", registryURL, oc.Namespace())
+
+		baseImg2, imageId, err := BuildAndPushImageOfSizeWithDocker(oc, dClient, "B", "latest", testImageSize, 2, outSink, true, false)
+		o.Expect(err).NotTo(o.HaveOccurred())
+		cleanUp.addImage(baseImg2, imageId, "")
+		baseImg2Spec := fmt.Sprintf("%s/%s/B:latest", registryURL, oc.Namespace())
+
+		baseImg3, imageId, err := BuildAndPushImageOfSizeWithDocker(oc, dClient, "C", "latest", testImageSize, 2, outSink, true, false)
+		o.Expect(err).NotTo(o.HaveOccurred())
+		cleanUp.addImage(baseImg3, imageId, "")
+		baseImg3Spec := fmt.Sprintf("%s/%s/C:latest", registryURL, oc.Namespace())
+
+		baseImg4, imageId, err := BuildAndPushImageOfSizeWithDocker(oc, dClient, "A", "latest", testImageSize, 2, outSink, true, false)
+		o.Expect(err).NotTo(o.HaveOccurred())
+		cleanUp.addImage(baseImg4, imageId, "")
+		//baseImg4Spec := fmt.Sprintf("%s/%s/A:new", registryURL, oc.Namespace())
+
+		childImg1, imageId, err := BuildAndPushChildImage(oc, dClient, baseImg1Spec, "A", "latest", 1, outSink, true)
+		o.Expect(err).NotTo(o.HaveOccurred())
+		cleanUp.addImage(childImg1, "", "")
+		childImg2, imageId, err := BuildAndPushChildImage(oc, dClient, baseImg2Spec, "B", "latest", 1, outSink, true)
+		o.Expect(err).NotTo(o.HaveOccurred())
+		cleanUp.addImage(childImg2, "", "")
+		childImg3, imageId, err := BuildAndPushChildImage(oc, dClient, baseImg3Spec, "D", "latest", 1, outSink, true)
+		o.Expect(err).NotTo(o.HaveOccurred())
+		cleanUp.addImage(childImg3, "", "")
+
+		err = oc.Run("tag").Args("--source=istag", "A:latest", "Atagged:latest").Execute()
+		o.Expect(err).NotTo(o.HaveOccurred())
+
+		imgs := map[string]*imageapi.Image{}
+		for _, imgName := range []string{baseImg1, baseImg2, baseImg3, baseImg4, childImg1, childImg2, childImg3} {
+			img, err := oc.AsAdmin().Client().Images().Get(imgName, metav1.GetOptions{})
+			o.Expect(err).NotTo(o.HaveOccurred())
+			imgs[imgName] = img
+			o.Expect(img.DockerImageManifestMediaType).To(o.Equal(schema2.MediaTypeManifest))
+		}
+
+		deleted, err := RunHardPrune(oc)
+		o.Expect(err).NotTo(o.HaveOccurred())
+		// this shouldn't delete anything
+		o.Expect(deleted).To(o.Equal([]string{}))
+
+		readOnly := true
+		err = registryutil.ConfigureRegistry(oc, registryutil.RegistryConfiguration{ReadOnly: &readOnly})
+		o.Expect(err).NotTo(o.HaveOccurred())
+
+		/* imageName  | parent   | layers | imagestreams
+		 * ---------- | -------- | ------ | ------------
+		 *  baseImg1  |          | 1 2    | A Atagged
+		 *  baseImg2  |          | 4 5    | B
+		 *  baseImg3  |          | 7 8    | C
+		 *  baseImg4  |          | 11 12  | A
+		 *  childImg1 | baseImg1 | 1 2 3  | C
+		 *  childImg2 | baseImg2 | 4 5 6  | B
+		 *  childImg3 | baseImg3 | 7 8 9  | D
+		 */
+
+		// verify that the registry doesn't accept any images
+		_, _, err = BuildAndPushImageOfSizeWithDocker(oc, dClient, "fail", "tag", testImageSize, 1, outSink, false, true)
+		o.Expect(err).NotTo(o.HaveOccurred())
+
+		err = oc.AsAdmin().Client().ImageStreamTags(oc.Namespace()).Delete("A", "latest")
+		deleted, err = RunHardPrune(oc)
+		o.Expect(err).NotTo(o.HaveOccurred())
+		err = expectDeletions(deleted, oc.Namespace(),
+			expectedDeletions{
+				manifestLinks: repoLink{"A": []string{baseImg1}},
+				layerLinks: repoLink{"A": []string{
+					imgs[baseImg1].DockerImageMetadata.ID,
+					imgs[baseImg1].DockerImageLayers[0].Name,
+					imgs[baseImg1].DockerImageLayers[1].Name,
+				}},
+				blobs: []string{imgs[baseImg1].DockerImageMetadata.ID},
+			})
+		o.Expect(err).NotTo(o.HaveOccurred())
+
+		err = oc.AsAdmin().Client().Images().Delete(childImg1)
+		deleted, err = RunHardPrune(oc)
+		o.Expect(err).NotTo(o.HaveOccurred())
+		err = expectDeletions(deleted, oc.Namespace(),
+			expectedDeletions{
+				manifestLinks: repoLink{"C": []string{childImg1}},
+				layerLinks: repoLink{"C": []string{
+					imgs[childImg1].DockerImageMetadata.ID,
+					imgs[childImg1].DockerImageLayers[0].Name,
+				}},
+				blobs: []string{
+					childImg1,
+					imgs[childImg1].DockerImageMetadata.ID,
+					imgs[childImg1].DockerImageLayers[0].Name,
+				},
+			})
+		o.Expect(err).NotTo(o.HaveOccurred())
+
+		err = oc.AsAdmin().Client().Images().Delete(baseImg1)
+		deleted, err = RunHardPrune(oc)
+		o.Expect(err).NotTo(o.HaveOccurred())
+		err = expectDeletions(deleted, oc.Namespace(),
+			expectedDeletions{
+				blobs: []string{
+					imgs[baseImg1].DockerImageLayers[0].Name,
+					imgs[baseImg1].DockerImageLayers[1].Name,
+				},
+			})
+		o.Expect(err).NotTo(o.HaveOccurred())
+
+		// TODO continue to remove images
+	})
+
+})
+
+func expectDeletions(deletedPaths []string, namespace string, expect expectedDeletions) error {
+	var errors []error
+	expectedPaths := sets.NewString()
+	deletedSet := sets.NewString()
+	verifiedSet := sets.NewString()
+
+	for repo, links := range expect.layerLinks {
+		for _, link := range links {
+			dgst := digest.Digest(link)
+			expectedPaths.Insert(fmt.Sprintf("v2/repositories/%s/%s/_layers/%s/%s/link",
+				namespace, repo, dgst.Algorithm(), dgst.Hex()))
+		}
+	}
+	for repo, links := range expect.manifestLinks {
+		for _, link := range links {
+			dgst := digest.Digest(link)
+			expectedPaths.Insert(fmt.Sprintf("v2/repositories/%s/%s/_manifests/revisions/%s/%s/link",
+				namespace, repo, dgst.Algorithm(), dgst.Hex()))
+		}
+	}
+	for _, blob := range expect.blobs {
+		dgst := digest.Digest(blob)
+		expectedPaths.Insert(fmt.Sprintf("v2/blobs/%s/%s/%s/data",
+			dgst.Algorithm(), dgst.Hex()[0:2], dgst.Hex()))
+	}
+
+	for _, pth := range deletedPaths {
+		deletedSet.Insert(pth)
+	}
+
+	for pth := range expectedPaths {
+		if deletedSet.Has(pth) {
+			verifiedSet.Insert(pth)
+		} else {
+			errors = append(errors, fmt.Errorf("expected path %s was not deleted", pth))
+		}
+	}
+	for pth := range deletedSet {
+		if !expectedPaths.Has(pth) {
+			errors = append(errors, fmt.Errorf("path %s got unexpectedly deleted", pth))
+		}
+	}
+
+	return kerrors.NewAggregate(errors)
+}