Skip to content

Commit b8b7b88

Browse files
Merge pull request #18321 from openshift-cherrypick-robot/cherry-pick-18182-to-release-3.8
Automatic merge from submit-queue. [release-3.8] Prometheus scrape is 60s, so ensure we see at least one This is an automated cherry-pick of #18182 /assign smarterclayton
2 parents 2d9534f + cc3fe73 commit b8b7b88

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

test/extended/prometheus/prometheus.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ var _ = g.Describe("[Feature:Prometheus][Conformance] Prometheus", func() {
4949
g.By("checking the unsecured metrics path")
5050
success := false
5151
var metrics map[string]*dto.MetricFamily
52-
for i := 0; i < 30; i++ {
52+
for i := 0; i < 120; i++ {
5353
results, err := getInsecureURLViaPod(ns, execPodName, fmt.Sprintf("https://%s:%d/metrics", host, statsPort))
5454
if err != nil {
5555
e2e.Logf("unable to get unsecured metrics: %v", err)
@@ -93,7 +93,7 @@ var _ = g.Describe("[Feature:Prometheus][Conformance] Prometheus", func() {
9393
g.By("verifying a service account token is able to access the Prometheus API")
9494
// expect all endpoints within 60 seconds
9595
var lastErrs []error
96-
for i := 0; i < 60; i++ {
96+
for i := 0; i < 120; i++ {
9797
contents, err := getBearerTokenURLViaPod(ns, execPodName, fmt.Sprintf("https://%s:%d/api/v1/targets", host, statsPort), bearerToken)
9898
o.Expect(err).NotTo(o.HaveOccurred())
9999

test/extended/prometheus/prometheus_builds.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ type metricTest struct {
129129
func runQueries(metricTests map[string][]metricTest) {
130130
// expect all correct metrics within 60 seconds
131131
errsMap := map[string]error{}
132-
for i := 0; i < 60; i++ {
132+
for i := 0; i < 120; i++ {
133133
for query, tcs := range metricTests {
134134
//TODO when the http/query apis discussed at https://github.com/prometheus/client_golang#client-for-the-prometheus-http-api
135135
// and introduced at https://github.com/prometheus/client_golang/blob/master/api/prometheus/v1/api.go are vendored into

0 commit comments

Comments
 (0)