|
| 1 | +package tnf |
| 2 | + |
| 3 | +import ( |
| 4 | + "context" |
| 5 | + "fmt" |
| 6 | + "math/rand" |
| 7 | + "slices" |
| 8 | + "time" |
| 9 | + |
| 10 | + g "github.com/onsi/ginkgo/v2" |
| 11 | + o "github.com/onsi/gomega" |
| 12 | + v1 "github.com/openshift/api/config/v1" |
| 13 | + "github.com/openshift/origin/test/extended/etcd/helpers" |
| 14 | + exutil "github.com/openshift/origin/test/extended/util" |
| 15 | + "go.etcd.io/etcd/api/v3/etcdserverpb" |
| 16 | + corev1 "k8s.io/api/core/v1" |
| 17 | + metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" |
| 18 | +) |
| 19 | + |
| 20 | +var _ = g.Describe("[sig-node][apigroup:config.openshift.io] Two Nodes OCP with fencing recovery", func() { |
| 21 | + defer g.GinkgoRecover() |
| 22 | + |
| 23 | + var ( |
| 24 | + oc = exutil.NewCLIWithoutNamespace("").AsAdmin() |
| 25 | + etcdClientFactory *helpers.EtcdClientFactoryImpl |
| 26 | + nodeA, nodeB corev1.Node |
| 27 | + ) |
| 28 | + |
| 29 | + g.BeforeEach(func() { |
| 30 | + infraStatus := getInfraStatus(oc) |
| 31 | + if infraStatus.ControlPlaneTopology != v1.DualReplicaTopologyMode { |
| 32 | + g.Skip("Cluster is not in DualReplicaTopologyMode skipping test") |
| 33 | + } |
| 34 | + |
| 35 | + nodes, err := oc.AdminKubeClient().CoreV1().Nodes().List(context.Background(), metav1.ListOptions{}) |
| 36 | + o.Expect(err).ShouldNot(o.HaveOccurred(), "Expected to retrieve nodes without error") |
| 37 | + o.Expect(len(nodes.Items)).To(o.BeNumerically("==", 2), "Expected to find 2 Nodes only") |
| 38 | + |
| 39 | + // Select the first index randomly |
| 40 | + randomIndex := rand.Intn(len(nodes.Items)) |
| 41 | + nodeA = nodes.Items[randomIndex] |
| 42 | + // Select the remaining index |
| 43 | + nodeB = nodes.Items[(randomIndex+1)%len(nodes.Items)] |
| 44 | + g.GinkgoT().Printf("Randomly selected %s to be gracefully shut down and %s to take the lead\n", nodeB.Name, nodeA.Name) |
| 45 | + |
| 46 | + kubeClient := oc.KubeClient() |
| 47 | + etcdClientFactory = helpers.NewEtcdClientFactory(kubeClient) |
| 48 | + |
| 49 | + o.Eventually(func() error { |
| 50 | + return helpers.EnsureHealthyMember(g.GinkgoT(), etcdClientFactory, nodeA.Name) |
| 51 | + }, time.Minute, 15*time.Second).ShouldNot(o.HaveOccurred(), "expect to ensure Node A healthy without error") |
| 52 | + |
| 53 | + o.Eventually(func() error { |
| 54 | + return helpers.EnsureHealthyMember(g.GinkgoT(), etcdClientFactory, nodeB.Name) |
| 55 | + }, time.Minute, 15*time.Second).ShouldNot(o.HaveOccurred(), "expect to ensure Node B healthy without error") |
| 56 | + }) |
| 57 | + |
| 58 | + g.It("Should support a graceful node shutdown", func() { |
| 59 | + msg := fmt.Sprintf("Shutting down %s gracefully in 1 minute", nodeB.Name) |
| 60 | + g.By(msg) |
| 61 | + // NOTE: Using `shutdown` alone would cause the node to be permanently removed from the cluster. |
| 62 | + // To prevent this, we use the `--reboot` flag, which ensures a graceful shutdown and allows the |
| 63 | + // node to rejoin the cluster upon restart. A one-minute delay is added to give the debug node |
| 64 | + // sufficient time to cleanly exit before the shutdown process completes. |
| 65 | + _, _, err := runOnNodeNS(oc, nodeB.Name, "openshift-etcd", "shutdown --reboot +1") |
| 66 | + o.Expect(err).To(o.BeNil(), "Expected to gracefully shutdown the node without errors") |
| 67 | + time.Sleep(time.Minute) |
| 68 | + |
| 69 | + msg = fmt.Sprintf("Ensuring %s leaves the member list", nodeB.Name) |
| 70 | + g.By(msg) |
| 71 | + o.Eventually(func() error { |
| 72 | + return helpers.EnsureMemberRemoved(g.GinkgoT(), etcdClientFactory, nodeB.Name) |
| 73 | + }, 5*time.Minute, 30*time.Second).ShouldNot(o.HaveOccurred()) |
| 74 | + |
| 75 | + msg = fmt.Sprintf("Ensuring that %s is a healthy voting member and adds %s back as learner", nodeA.Name, nodeB.Name) |
| 76 | + g.By(msg) |
| 77 | + o.Eventually(func() error { |
| 78 | + members, err := getMembers(etcdClientFactory) |
| 79 | + if err != nil { |
| 80 | + return err |
| 81 | + } |
| 82 | + if len(members) != 2 { |
| 83 | + return fmt.Errorf("Not enough members") |
| 84 | + } |
| 85 | + |
| 86 | + if started, learner, err := getMemberState(&nodeA, members); err != nil { |
| 87 | + return err |
| 88 | + } else if !started || learner { |
| 89 | + return fmt.Errorf("Expected node: %s to be a started and voting member. Membership: %+v", nodeA.Name, members) |
| 90 | + } |
| 91 | + |
| 92 | + // Ensure GNS node is unstarted and a learner member (i.e. !learner) |
| 93 | + if started, learner, err := getMemberState(&nodeB, members); err != nil { |
| 94 | + return err |
| 95 | + } else if started || !learner { |
| 96 | + return fmt.Errorf("Expected node: %s to be a unstarted and learning member. Membership: %+v", nodeB.Name, members) |
| 97 | + } |
| 98 | + |
| 99 | + g.GinkgoT().Logf("membership: %+v", members) |
| 100 | + return nil |
| 101 | + }, 2*time.Minute, 15*time.Second).Should(o.BeNil()) |
| 102 | + |
| 103 | + msg = fmt.Sprintf("Ensuring %s rejoins as learner", nodeB.Name) |
| 104 | + g.By(msg) |
| 105 | + o.Eventually(func() error { |
| 106 | + members, err := getMembers(etcdClientFactory) |
| 107 | + if err != nil { |
| 108 | + return err |
| 109 | + } |
| 110 | + if len(members) != 2 { |
| 111 | + return fmt.Errorf("Not enough members") |
| 112 | + } |
| 113 | + |
| 114 | + if started, learner, err := getMemberState(&nodeA, members); err != nil { |
| 115 | + return err |
| 116 | + } else if !started || learner { |
| 117 | + return fmt.Errorf("Expected node: %s to be a started and voting member. Membership: %+v", nodeA.Name, members) |
| 118 | + } |
| 119 | + |
| 120 | + if started, learner, err := getMemberState(&nodeB, members); err != nil { |
| 121 | + return err |
| 122 | + } else if !started || !learner { |
| 123 | + return fmt.Errorf("Expected node: %s to be a started and learner member. Membership: %+v", nodeB.Name, members) |
| 124 | + } |
| 125 | + |
| 126 | + g.GinkgoT().Logf("membership: %+v", members) |
| 127 | + return nil |
| 128 | + }, 10*time.Minute, 15*time.Second).Should(o.BeNil()) |
| 129 | + |
| 130 | + msg = fmt.Sprintf("Ensuring %s node is promoted back as voting member", nodeB.Name) |
| 131 | + g.By(msg) |
| 132 | + o.Eventually(func() error { |
| 133 | + members, err := getMembers(etcdClientFactory) |
| 134 | + if err != nil { |
| 135 | + return err |
| 136 | + } |
| 137 | + if len(members) != 2 { |
| 138 | + return fmt.Errorf("Not enough members") |
| 139 | + } |
| 140 | + |
| 141 | + if started, learner, err := getMemberState(&nodeA, members); err != nil { |
| 142 | + return err |
| 143 | + } else if !started || learner { |
| 144 | + return fmt.Errorf("Expected node: %s to be a started and voting member. Membership: %+v", nodeA.Name, members) |
| 145 | + } |
| 146 | + |
| 147 | + if started, learner, err := getMemberState(&nodeB, members); err != nil { |
| 148 | + return err |
| 149 | + } else if !started || learner { |
| 150 | + return fmt.Errorf("Expected node: %s to be a started and voting member. Membership: %+v", nodeB.Name, members) |
| 151 | + } |
| 152 | + |
| 153 | + g.GinkgoT().Logf("membership: %+v", members) |
| 154 | + return nil |
| 155 | + }, 10*time.Minute, 15*time.Second).Should(o.Succeed()) |
| 156 | + }) |
| 157 | +}) |
| 158 | + |
| 159 | +func getMembers(etcdClientFactory helpers.EtcdClientCreator) ([]*etcdserverpb.Member, error) { |
| 160 | + etcdClient, closeFn, err := etcdClientFactory.NewEtcdClient() |
| 161 | + defer closeFn() |
| 162 | + if err != nil { |
| 163 | + return nil, err |
| 164 | + } |
| 165 | + ctx, cancel := context.WithTimeout(context.TODO(), 10*time.Second) |
| 166 | + defer cancel() |
| 167 | + m, err := etcdClient.MemberList(ctx) |
| 168 | + if err != nil { |
| 169 | + return nil, fmt.Errorf("failed to get the member list, err: %w", err) |
| 170 | + } |
| 171 | + return m.Members, nil |
| 172 | +} |
| 173 | + |
| 174 | +func getMemberState(node *corev1.Node, members []*etcdserverpb.Member) (started, learner bool, err error) { |
| 175 | + // Etcd members that have been added to the member list but haven't |
| 176 | + // joined yet will have an empty Name field. We can match them via Peer URL. |
| 177 | + peerURL := fmt.Sprintf("https://%s:2380", node.Status.Addresses[0].Address) |
| 178 | + var found bool |
| 179 | + for _, m := range members { |
| 180 | + if m.Name == node.Name { |
| 181 | + found = true |
| 182 | + started = true |
| 183 | + learner = m.IsLearner |
| 184 | + break |
| 185 | + } |
| 186 | + if slices.Contains(m.PeerURLs, peerURL) { |
| 187 | + found = true |
| 188 | + learner = m.IsLearner |
| 189 | + break |
| 190 | + } |
| 191 | + } |
| 192 | + if !found { |
| 193 | + return false, false, fmt.Errorf("could not find node %v", node.Name) |
| 194 | + } |
| 195 | + return started, learner, nil |
| 196 | +} |
0 commit comments