Create a generic trigger controller for image streams

Author: smarterclayton

pkg/image/api/helper.go

@@ -600,7 +600,10 @@ func ResolveLatestTaggedImage(stream *ImageStream, tag string) (string, bool) {
 	if latest == nil {
 		return "", false
 	}
+	return ResolveTagReference(stream, tag, latest)
+}
 
+func ResolveTagReference(stream *ImageStream, tag string, latest *TagEvent) (string, bool) {
 	// retrieve spec policy - if not found, we use the latest spec
 	ref, ok := stream.Spec.Tags[tag]
 	if !ok {

pkg/image/api/v1/trigger/trigger.go

@@ -0,0 +1,24 @@
+package trigger
+
+// ObjectFieldTrigger links a field on the current object to another object for mutation.
+type ObjectFieldTrigger struct {
+	// from is the object this should trigger from. The kind and name fields must be set.
+	From ObjectReference `json:"from"`
+	// fieldPath is a JSONPath string to the field to edit on the object. Required.
+	FieldPath string `json:"fieldPath"`
+	// paused is true if this trigger is temporarily disabled. Optional.
+	Paused bool `json:"paused,omitempty"`
+}
+
+// ObjectReference identifies an object by its name and kind.
+type ObjectReference struct {
+	// kind is the referenced object's schema.
+	Kind string `json:"kind"`
+	// name is the name of the object.
+	Name string `json:"name"`
+	// namespace is the namespace the object is located in. Optional if the object is not
+	// namespaced, or if left empty on a namespaced object, means the current namespace.
+	Namespace string `json:"namespace,omitempty"`
+	// apiVersion is the group and version the type exists in. Optional.
+	APIVersion string `json:"apiVersion,omitempty"`
+}

pkg/image/controller/trigger/annotations.go

@@ -0,0 +1,29 @@
+package trigger
+
+import (
+	"encoding/json"
+
+	"k8s.io/client-go/pkg/api/meta"
+)
+
+// TODO: WIP not yet updated
+func AnnotationTriggerIndex(prefix string, obj interface{}) (string, interface{}, bool, error) {
+	m, err := meta.Accessor(obj)
+	if err != nil {
+		return "", nil, false, err
+	}
+	t, ok := m.GetAnnotations()["image.openshift.io/triggers"]
+	if !ok {
+		return "", nil, false, nil
+	}
+	r := &TriggerCacheEntry{}
+	if err := json.Unmarshal([]byte(t), &r.Triggers); err != nil {
+		return "", nil, false, err
+	}
+	if len(r.Triggers) == 0 {
+		return "", nil, false, nil
+	}
+	r.Namespace = m.GetNamespace()
+	key := r.Namespace + "/" + m.GetName()
+	return key, r, true, nil
+}

pkg/image/controller/trigger/buildconfigs.go

@@ -0,0 +1,205 @@
+package trigger
+
+import (
+	"fmt"
+	"reflect"
+
+	kapi "k8s.io/kubernetes/pkg/api"
+	kerrors "k8s.io/kubernetes/pkg/api/errors"
+	"k8s.io/kubernetes/pkg/client/cache"
+	utilruntime "k8s.io/kubernetes/pkg/util/runtime"
+
+	"github.com/golang/glog"
+	buildapi "github.com/openshift/origin/pkg/build/api"
+	buildutil "github.com/openshift/origin/pkg/build/util"
+	imageapi "github.com/openshift/origin/pkg/image/api"
+	"github.com/openshift/origin/pkg/image/api/v1/trigger"
+)
+
+func calculateBuildConfigTriggers(bc *buildapi.BuildConfig, retrieveOperations bool) ([]trigger.ObjectFieldTrigger, []TriggerOperation) {
+	var triggers []trigger.ObjectFieldTrigger
+	var operations []TriggerOperation
+	for _, t := range bc.Spec.Triggers {
+		if t.ImageChange == nil {
+			continue
+		}
+		var (
+			fieldPath string
+			from      *kapi.ObjectReference
+		)
+		if t.ImageChange.From != nil {
+			from = t.ImageChange.From
+			fieldPath = "spec.triggers"
+		} else {
+			from = buildutil.GetInputReference(bc.Spec.Strategy)
+			fieldPath = "spec.strategy.*.from"
+		}
+		if from == nil || from.Kind != "ImageStreamTag" || len(from.Name) == 0 {
+			continue
+		}
+
+		// add a trigger
+		triggers = append(triggers, trigger.ObjectFieldTrigger{
+			From: trigger.ObjectReference{
+				Name:       from.Name,
+				Namespace:  from.Namespace,
+				Kind:       from.Kind,
+				APIVersion: from.APIVersion,
+			},
+			FieldPath: fieldPath,
+		})
+
+		// find the current trigger value as an operation if requested
+		if !retrieveOperations {
+			continue
+		}
+		namespace := from.Namespace
+		if len(namespace) == 0 {
+			namespace = bc.Namespace
+		}
+		_, tag, ok := imageapi.SplitImageStreamTag(from.Name)
+		if !ok {
+			utilruntime.HandleError(fmt.Errorf("unable to trigger image change - tag reference %s on build config %s/%s not valid", from.Name, bc.Namespace, bc.Name))
+			continue
+		}
+		operations = append(operations, TriggerOperation{
+			Name:      from.Name,
+			Tag:       tag,
+			Ref:       t.ImageChange.LastTriggeredImageID,
+			Namespace: namespace,
+			RV:        0,
+			Trigger:   &triggers[len(triggers)-1],
+		})
+	}
+	return triggers, operations
+}
+
+type buildConfigTriggerIndexer struct {
+	prefix string
+}
+
+func (i buildConfigTriggerIndexer) Index(obj, old interface{}) (string, *TriggerCacheEntry, []TriggerOperation, cache.DeltaType, error) {
+	var (
+		triggers   []trigger.ObjectFieldTrigger
+		operations []TriggerOperation
+		bc         *buildapi.BuildConfig
+		change     cache.DeltaType
+	)
+	switch {
+	case obj != nil && old == nil:
+		// added
+		bc = obj.(*buildapi.BuildConfig)
+		triggers, operations = calculateBuildConfigTriggers(bc, true)
+		change = cache.Added
+	case old != nil && obj == nil:
+		// deleted
+		bc = old.(*buildapi.BuildConfig)
+		triggers, _ = calculateBuildConfigTriggers(bc, false)
+		change = cache.Deleted
+	default:
+		// updated
+		bc = obj.(*buildapi.BuildConfig)
+		triggers, operations = calculateBuildConfigTriggers(bc, true)
+		oldTriggers, _ := calculateBuildConfigTriggers(old.(*buildapi.BuildConfig), false)
+		switch {
+		case len(oldTriggers) == 0:
+			change = cache.Added
+		case !reflect.DeepEqual(oldTriggers, triggers):
+			change = cache.Updated
+		}
+	}
+
+	if len(triggers) > 0 {
+		key := i.prefix + bc.Namespace + "/" + bc.Name
+		return key, &TriggerCacheEntry{
+			Key:       key,
+			Namespace: bc.Namespace,
+			Triggers:  triggers,
+		}, operations, change, nil
+	}
+	return "", nil, nil, change, nil
+}
+
+type BuildConfigInstantiator interface {
+	Instantiate(namespace string, request *buildapi.BuildRequest) (*buildapi.Build, error)
+}
+
+type BuildConfigReaction struct {
+	Instantiator BuildConfigInstantiator
+}
+
+func (r *BuildConfigReaction) ImageChanged(obj interface{}, operations []TriggerOperation) error {
+	bc := obj.(*buildapi.BuildConfig)
+	var (
+		changed bool
+		id      string
+		from    *kapi.ObjectReference
+		ref     string
+	)
+	for _, t := range bc.Spec.Triggers {
+		if t.ImageChange == nil {
+			continue
+		}
+		for _, operation := range operations {
+			switch operation.Trigger.FieldPath {
+			case "spec.strategy.*.from":
+				if t.ImageChange.From != nil {
+					continue
+				}
+			case "spec.triggers":
+				if t.ImageChange.From == nil || t.ImageChange.From.Name != operation.Name || t.ImageChange.From.Namespace != operation.Namespace {
+					continue
+				}
+			}
+			if t.ImageChange.LastTriggeredImageID != operation.Ref {
+				changed = true
+				//id = operation.ID
+				ref = operation.Ref
+				from = t.ImageChange.From
+				if from == nil {
+					from = buildutil.GetInputReference(bc.Spec.Strategy)
+				}
+				copied := *from
+				from = &copied
+			}
+			break
+		}
+	}
+
+	if !changed {
+		return nil
+	}
+
+	// instantiate new build
+	glog.V(4).Infof("Running build for BuildConfig %s/%s", bc.Namespace, bc.Name)
+	request := &buildapi.BuildRequest{
+		ObjectMeta: kapi.ObjectMeta{
+			Name:      bc.Name,
+			Namespace: bc.Namespace,
+		},
+		TriggeredBy: []buildapi.BuildTriggerCause{
+			{
+				Message: buildapi.BuildTriggerCauseImageMsg,
+				ImageChangeBuild: &buildapi.ImageChangeCause{
+					ImageID: id,
+					FromRef: from,
+				},
+			},
+		},
+		TriggeredByImage: &kapi.ObjectReference{
+			Kind: "DockerImage",
+			Name: ref,
+		},
+		From: from,
+	}
+	if _, err := r.Instantiator.Instantiate(bc.Namespace, request); err != nil {
+		if kerrors.IsConflict(err) {
+			utilruntime.HandleError(fmt.Errorf("unable to instantiate Build for BuildConfig %s/%s due to a conflicting update: %v", bc.Namespace, bc.Name, err))
+		} else {
+			utilruntime.HandleError(fmt.Errorf("error instantiating Build from BuildConfig %s/%s: %v", bc.Namespace, bc.Name, err))
+		}
+		return err
+	}
+
+	return nil
+}