update liveness probe check

Author: juanvallejo

pkg/api/kubegraph/analysis/podspec.go

@@ -82,18 +82,23 @@ func FindMissingLivenessProbes(g osgraph.Graph, f osgraph.Namer, setProbeCommand
 
 	for _, uncastPodSpecNode := range g.NodesByKind(kubegraph.PodSpecNodeKind) {
 		podSpecNode := uncastPodSpecNode.(*kubegraph.PodSpecNode)
-		topLevelNode := osgraph.GetTopLevelContainerNode(g, podSpecNode)
-
 		if hasLivenessProbe(podSpecNode) {
 			continue
 		}
+
+		topLevelNode := osgraph.GetTopLevelContainerNode(g, podSpecNode)
+
+		// skip any podSpec nodes that are managed by other nodes.
+		// Liveness probes should only be applied to a controlling
+		// podSpec node, and not to any of its children.
 		if hasControllerRefEdge(g, topLevelNode) {
 			continue
 		}
 
 		topLevelString := f.ResourceName(topLevelNode)
 		markers = append(markers, osgraph.Marker{
-			Node: podSpecNode,
+			Node:         podSpecNode,
+			RelatedNodes: []graph.Node{topLevelNode},
 
 			Severity: osgraph.WarningSeverity,
 			Key:      MissingLivenessProbeWarning,
@@ -117,17 +122,10 @@ func hasLivenessProbe(podSpecNode *kubegraph.PodSpecNode) bool {
 	return false
 }
 
-// hasControllerRefEdge returns true if a given node contains a "ManagedByController" edge between itself and any of its "To" nodes.
+// hasControllerRefEdge returns true if a given node contains one or more "ManagedByController" outbound edges
 func hasControllerRefEdge(g osgraph.Graph, node graph.Node) bool {
-	children := g.From(node)
-	for _, child := range children {
-		edge := g.Edge(node, child)
-		edgeKinds := g.EdgeKinds(edge)
-		if edgeKinds.Has(kubeedges.ManagedByControllerEdgeKind) {
-			return true
-		}
-	}
-	return false
+	managedEdges := g.OutboundEdges(node, kubeedges.ManagedByControllerEdgeKind)
+	return len(managedEdges) > 0
 }
 
 // CheckForUnmountableSecrets checks to be sure that all the referenced secrets are mountable (by service account)