Skip to content

Commit d8a2c2c

Browse files
committed
use correct context dir during s2i build
1 parent 03beb95 commit d8a2c2c

File tree

1 file changed

+12
-5
lines changed

1 file changed

+12
-5
lines changed

pkg/build/builder/sti.go

Lines changed: 12 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -121,19 +121,24 @@ func (s *S2IBuilder) Build() error {
121121
handleBuildStatusUpdate(s.build, s.client, nil)
122122
return err
123123
}
124+
contextDir := ""
124125
if len(s.build.Spec.Source.ContextDir) > 0 {
125-
contextDir := filepath.Clean(s.build.Spec.Source.ContextDir)
126+
contextDir = filepath.Clean(s.build.Spec.Source.ContextDir)
126127
if contextDir == "." || contextDir == "/" {
127128
contextDir = ""
128129
}
129130
if sourceInfo != nil {
130131
sourceInfo.ContextDir = s.build.Spec.Source.ContextDir
131132
}
132-
srcDir = filepath.Join(srcDir, s.build.Spec.Source.ContextDir)
133+
//srcDir = filepath.Join(srcDir, s.build.Spec.Source.ContextDir)
133134
}
134-
download := &downloader{}
135+
//download := &downloader{}
136+
//download = nil
137+
138+
var s2iSourceInfo *s2iapi.SourceInfo
135139
if sourceInfo != nil {
136-
download.sourceInfo = &sourceInfo.SourceInfo
140+
//download.sourceInfo = &sourceInfo.SourceInfo
141+
s2iSourceInfo = &sourceInfo.SourceInfo
137142
revision := updateBuildRevision(s.build, sourceInfo)
138143
handleBuildStatusUpdate(s.build, s.client, revision)
139144
}
@@ -182,6 +187,8 @@ func (s *S2IBuilder) Build() error {
182187
DockerNetworkMode: getDockerNetworkMode(),
183188

184189
Source: srcDir,
190+
ContextDir: contextDir,
191+
SourceInfo: s2iSourceInfo,
185192
ForceCopy: true,
186193
Injections: injections,
187194

@@ -241,7 +248,7 @@ func (s *S2IBuilder) Build() error {
241248
}
242249

243250
glog.V(4).Infof("Creating a new S2I builder with build config: %#v\n", describe.Config(config))
244-
builder, buildInfo, err := s.builder.Builder(config, s2ibuild.Overrides{Downloader: download})
251+
builder, buildInfo, err := s.builder.Builder(config, s2ibuild.Overrides{Downloader: nil})
245252
if err != nil {
246253
s.build.Status.Reason, s.build.Status.Message = convertS2IFailureType(
247254
buildInfo.FailureReason.Reason,

0 commit comments

Comments
 (0)