Merge pull request #18706 from Oats87/surpress-over-50

Automatic merge from submit-queue.

Surpress project list on login if you have access to greater than 50 projects

As a compromise to #18684 we are going to surpress the project list functionality if the number of projects available to a user is greater than 50

Original RFE was at BZ #1542326 - https://bugzilla.redhat.com/show_bug.cgi?id=1542326
RFE is within that BZ, but there was a compromise.

Author: openshift-merge-robot

pkg/oc/cli/cmd/login/loginoptions.go

@@ -34,6 +34,8 @@ import (
 
 const defaultClusterURL = "https://localhost:8443"
 
+const projectsItemsSuppressThreshold = 50
+
 // LoginOptions is a helper for the login and setup process, gathers all information required for a
 // successful login and eventual update of config files.
 // Depending on the Reader present it can be interactive, asking for terminal input in
@@ -317,15 +319,20 @@ func (o *LoginOptions) gatherProjectInfo() error {
 		}
 		o.Project = current.Name
 
-		fmt.Fprintf(o.Out, "You have access to the following projects and can switch between them with '%s project <projectname>':\n\n", o.CommandName)
-		for _, p := range projects.List() {
-			if o.Project == p {
-				fmt.Fprintf(o.Out, "  * %s\n", p)
-			} else {
-				fmt.Fprintf(o.Out, "    %s\n", p)
+		// Suppress project listing if the number of projects available to the user is greater than the threshold. Prevents unnecessarily noisy logins on clusters with large numbers of projects
+		if len(projectsItems) > projectsItemsSuppressThreshold {
+			fmt.Fprintf(o.Out, "You have access to %d projects, the list has been suppressed. You can list all projects with '%s projects'\n\n", len(projectsItems), o.CommandName)
+		} else {
+			fmt.Fprintf(o.Out, "You have access to the following projects and can switch between them with '%s project <projectname>':\n\n", o.CommandName)
+			for _, p := range projects.List() {
+				if o.Project == p {
+					fmt.Fprintf(o.Out, "  * %s\n", p)
+				} else {
+					fmt.Fprintf(o.Out, "    %s\n", p)
+				}
 			}
+			fmt.Fprintln(o.Out)
 		}
-		fmt.Fprintln(o.Out)
 		fmt.Fprintf(o.Out, "Using project %q.\n", o.Project)
 	}