Skip to content

Commit dbfc263

Browse files
committed
collapse onto upstream version function
1 parent 063d5b9 commit dbfc263

File tree

7 files changed

+20
-225
lines changed

7 files changed

+20
-225
lines changed

contrib/completions/bash/oc

Lines changed: 8 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

contrib/completions/zsh/oc

Lines changed: 8 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

hack/import-restrictions.json

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -618,15 +618,13 @@
618618

619619
"vendor/github.com/coreos/etcd/clientv3",
620620
"vendor/github.com/coreos/etcd/pkg/transport",
621-
"vendor/github.com/coreos/etcd/version",
622621
"vendor/github.com/ghodss/yaml",
623622

624623
"vendor/k8s.io/kubernetes/pkg/api/legacyscheme",
625624
"vendor/k8s.io/kubernetes/pkg/controller",
626625
"vendor/k8s.io/kubernetes/pkg/controller/deployment/util",
627626
"vendor/k8s.io/kubernetes/pkg/credentialprovider",
628627
"vendor/k8s.io/kubernetes/pkg/serviceaccount",
629-
"vendor/k8s.io/kubernetes/pkg/version",
630628

631629
"vendor/github.com/openshift/library-go/pkg/git"
632630
]

pkg/oc/cli/admin/admin.go

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,6 @@ import (
4040
"github.com/openshift/origin/pkg/oc/cli/admin/verifyimagesignature"
4141
"github.com/openshift/origin/pkg/oc/cli/kubectlwrappers"
4242
"github.com/openshift/origin/pkg/oc/cli/options"
43-
"github.com/openshift/origin/pkg/oc/cli/version"
4443
)
4544

4645
var adminLong = ktemplates.LongDesc(`
@@ -160,9 +159,5 @@ func NewCommandAdmin(name, fullName string, f kcmdutil.Factory, streams genericc
160159
options.NewCmdOptions(streams),
161160
)
162161

163-
if name == fullName {
164-
cmds.AddCommand(version.NewCmdVersion(fullName, f, version.NewVersionOptions(false, streams)))
165-
}
166-
167162
return cmds
168163
}

pkg/oc/cli/cli.go

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,6 @@ import (
5858
"github.com/openshift/origin/pkg/oc/cli/startbuild"
5959
"github.com/openshift/origin/pkg/oc/cli/status"
6060
"github.com/openshift/origin/pkg/oc/cli/tag"
61-
"github.com/openshift/origin/pkg/oc/cli/version"
6261
"github.com/openshift/origin/pkg/oc/cli/whoami"
6362
)
6463

@@ -262,9 +261,7 @@ func NewOcCommand(name, fullName string, in io.Reader, out, errout io.Writer) *c
262261
cmds.AddCommand(newExperimentalCommand("ex", name+" ex", f, ioStreams))
263262

264263
cmds.AddCommand(kubectlwrappers.NewCmdPlugin(fullName, f, ioStreams))
265-
if name == fullName {
266-
cmds.AddCommand(version.NewCmdVersion(fullName, f, version.NewVersionOptions(true, ioStreams)))
267-
}
264+
cmds.AddCommand(kubecmd.NewCmdVersion(f, ioStreams))
268265
cmds.AddCommand(options.NewCmdOptions(ioStreams))
269266

270267
if cmds.Flag("namespace") != nil {

pkg/oc/cli/shim_kubectl.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,13 +4,15 @@ import (
44
"k8s.io/cli-runtime/pkg/genericclioptions"
55
"k8s.io/cli-runtime/pkg/genericclioptions/openshiftpatch"
66
kclientcmd "k8s.io/client-go/tools/clientcmd"
7+
kcmd "k8s.io/kubernetes/pkg/kubectl/cmd"
78
kcmdset "k8s.io/kubernetes/pkg/kubectl/cmd/set"
89
kcmdutil "k8s.io/kubernetes/pkg/kubectl/cmd/util"
910
"k8s.io/kubernetes/pkg/kubectl/polymorphichelpers"
1011

1112
"github.com/openshift/origin/pkg/api/legacygroupification"
1213
"github.com/openshift/origin/pkg/oc/originpolymorphichelpers"
1314
"github.com/openshift/origin/pkg/oc/util/clientcmd"
15+
"github.com/openshift/origin/pkg/version"
1416
)
1517

1618
func shimKubectlForOc() {
@@ -41,4 +43,5 @@ func shimKubectlForOc() {
4143
// update some functions we inject
4244
kcmdutil.GeneratorFn = originpolymorphichelpers.NewGeneratorsFn(kcmdutil.GeneratorFn)
4345
kcmdutil.DescriberFn = originpolymorphichelpers.NewDescriberFn(kcmdutil.DescriberFn)
46+
kcmd.OverrideGetVersionFn = version.Get
4447
}

pkg/oc/cli/version/version.go

Lines changed: 0 additions & 214 deletions
This file was deleted.

0 commit comments

Comments
 (0)