Skip to content

Commit e13aa42

Browse files
committed
Bring back deployment e2e commented out due to journald limitting problem
1 parent 3906907 commit e13aa42

File tree

1 file changed

+3
-12
lines changed

1 file changed

+3
-12
lines changed

test/extended/deployments/deployments.go

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -301,10 +301,7 @@ var _ = g.Describe("[Feature:DeploymentConfig] deploymentconfigs", func() {
301301
g.By(fmt.Sprintf("checking the logs for substrings\n%s", out))
302302
o.Expect(out).To(o.ContainSubstring("deployment-test-1 to 2"))
303303
o.Expect(out).To(o.ContainSubstring("--> pre: Success"))
304-
// FIXME: In some cases the last log messages is lost because of the journald rate
305-
// limiter bug. For this test it should be enough to verify the deployment is marked
306-
// as complete. We should uncomment this once the rate-limiter issues are fixed.
307-
// o.Expect(out).To(o.ContainSubstring("--> Success"))
304+
o.Expect(out).To(o.ContainSubstring("--> Success"))
308305

309306
g.By("verifying the deployment is marked complete and scaled to zero")
310307
o.Expect(waitForLatestCondition(oc, "deployment-test", deploymentRunTimeout, deploymentReachedCompletion)).NotTo(o.HaveOccurred())
@@ -354,10 +351,7 @@ var _ = g.Describe("[Feature:DeploymentConfig] deploymentconfigs", func() {
354351
o.Expect(out).To(o.ContainSubstring(fmt.Sprintf("deployment-test-%d up to 1", i+2)))
355352
o.Expect(out).To(o.ContainSubstring("--> pre: Success"))
356353
o.Expect(out).To(o.ContainSubstring("test pre hook executed"))
357-
// FIXME: In some cases the last log messages is lost because of the journald rate
358-
// limiter bug. For this test it should be enough to verify the deployment is marked
359-
// as complete. We should uncomment this once the rate-limiter issues are fixed.
360-
// o.Expect(out).To(o.ContainSubstring("--> Success"))
354+
o.Expect(out).To(o.ContainSubstring("--> Success"))
361355
}
362356
})
363357
})
@@ -556,10 +550,7 @@ var _ = g.Describe("[Feature:DeploymentConfig] deploymentconfigs", func() {
556550
o.Expect(out).To(o.ContainSubstring("--> Reached 50%"))
557551
o.Expect(out).To(o.ContainSubstring("Halfway"))
558552
o.Expect(out).To(o.ContainSubstring("Finished"))
559-
// FIXME: In some cases the last log messages is lost because of the journald rate
560-
// limiter bug. For this test it should be enough to verify the deployment is marked
561-
// as complete. We should uncomment this once the rate-limiter issues are fixed.
562-
// o.Expect(out).To(o.ContainSubstring("--> Success"))
553+
o.Expect(out).To(o.ContainSubstring("--> Success"))
563554
})
564555
})
565556

0 commit comments

Comments
 (0)