Skip to content

Commit e38f696

Browse files
committed
Modify validation conditions
1 parent a289a74 commit e38f696

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

pkg/cmd/admin/network/project_options.go

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ import (
1111
"github.com/spf13/cobra"
1212

1313
kapi "k8s.io/kubernetes/pkg/api"
14+
kapierrors "k8s.io/kubernetes/pkg/api/errors"
1415
"k8s.io/kubernetes/pkg/api/meta"
1516
kclient "k8s.io/kubernetes/pkg/client/unversioned"
1617
"k8s.io/kubernetes/pkg/kubectl/resource"
@@ -86,10 +87,13 @@ func (p *ProjectOptions) Validate() error {
8687

8788
clusterNetwork, err := p.Oclient.ClusterNetwork().Get(sdnapi.ClusterNetworkDefault)
8889
if err != nil {
89-
errList = append(errList, errors.New("could not manage pod network: error on getting the running network plugin"))
90+
if kapierrors.IsNotFound(err) {
91+
errList = append(errList, errors.New("Managing pod network is only supported for openshift multitenant network plugin"))
92+
} else {
93+
errList = append(errList, errors.New("Failed to fetch current network plugin info"))
94+
}
9095
} else if !sdnapi.IsOpenShiftMultitenantNetworkPlugin(clusterNetwork.PluginName) {
91-
err := fmt.Errorf("could not manage pod network: the running plugin %s is not OpenShift mutitenant network plugin", clusterNetwork.PluginName)
92-
errList = append(errList, err)
96+
errList = append(errList, fmt.Errorf("Using plugin: %q, managing pod network is only supported for openshift multitenant network plugin", clusterNetwork.PluginName))
9397
}
9498

9599
return kerrors.NewAggregate(errList)

0 commit comments

Comments
 (0)