make oc login kubeconfig permission error clearer

juanvallejo · juanvallejo · commit ec5b7eb8f7fa · 2016-07-20T18:10:03.000-04:00
diff --git a/pkg/cmd/cli/cmd/loginoptions.go b/pkg/cmd/cli/cmd/loginoptions.go
@@ -394,7 +394,11 @@ func (o *LoginOptions) SaveConfig() (bool, error) {
 	}
 
 	if err := kclientcmd.ModifyConfig(o.PathOptions, *configToWrite, true); err != nil {
-		return false, err
+		errorSuggestion := "Make sure that the --config flag passed contains the correct path:"
+		if !o.PathOptions.IsExplicitFile() {
+			errorSuggestion = "Make sure that your $KUBECONFIG variable is exported with the correct path:"
+		}
+		return false, fmt.Errorf("Failed to create kubeconfig under %s. %s %v\n", o.PathOptions.GetDefaultFilename(), errorSuggestion, err)
 	}
 
 	created := false

Original file line number	Diff line number	Diff line change
`@@ -394,7 +394,11 @@ func (o *LoginOptions) SaveConfig() (bool, error) {`
`394`	`394`	`}`
`395`	`395`
`396`	`396`	`if err := kclientcmd.ModifyConfig(o.PathOptions, *configToWrite, true); err != nil {`
`397`		`- return false, err`
	`397`	`+ errorSuggestion := "Make sure that the --config flag passed contains the correct path:"`
	`398`	`+ if !o.PathOptions.IsExplicitFile() {`
	`399`	`+ errorSuggestion = "Make sure that your $KUBECONFIG variable is exported with the correct path:"`
	`400`	`+ }`
	`401`	`+ return false, fmt.Errorf("Failed to create kubeconfig under %s. %s %v\n", o.PathOptions.GetDefaultFilename(), errorSuggestion, err)`
`398`	`402`	`}`
`399`	`403`
`400`	`404`	`created := false`