Skip to content

Commit f705544

Browse files
author
Ravi Sankar Penta
committed
Use KubeletServer.NodeIP instead of KubeletServer.HostnameOverride to set node IP
1 parent 0e44f8b commit f705544

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

pkg/cmd/server/kubernetes/node_config.go

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -109,14 +109,14 @@ func BuildKubernetesNodeConfig(options configapi.NodeConfig) (*NodeConfig, error
109109
server.Config = path
110110
server.RootDirectory = options.VolumeDirectory
111111

112-
// kubelet finds the node IP address by doing net.ParseIP(hostname) and if that fails,
113-
// it does net.LookupIP(NodeName) and picks the first non-loopback address.
114-
// Pass node IP as hostname to make kubelet use the desired IP address.
115112
if len(options.NodeIP) > 0 {
116-
server.HostnameOverride = options.NodeIP
117-
} else {
118-
server.HostnameOverride = options.NodeName
113+
nodeIP := net.ParseIP(options.NodeIP)
114+
if nodeIP == nil {
115+
return nil, fmt.Errorf("Invalid Node IP: %s", options.NodeIP)
116+
}
117+
server.NodeIP = nodeIP
119118
}
119+
server.HostnameOverride = options.NodeName
120120
server.AllowPrivileged = true
121121
server.RegisterNode = true
122122
server.Address = kubeAddress

0 commit comments

Comments
 (0)