Flake cover: internal error: block 264 overlaps block 266

[soltysh]

This was noticed in #10293, full log is here: https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_origin_check/4739/consoleFull

In suite "github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/util/dbus", test case "TestRealDBus" was skipped:
=== RUN   TestRealDBus
--- SKIP: TestRealDBus (0.00s)
    dbus_test.go:73: D-Bus session bus is not available: exec: "dbus-launch": executable file not found in $PATH

[liggitt]

I don't think the skip error is the one that failed:

[WARNING] While the jUnit report found no failed tests, the `go test` process failed.
[WARNING] This usually means that the unit test suite failed to compile.
[WARNING] `go test` had the following output to stderr:
# cover github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/client/restclient
cover: internal error: block 264 overlaps block 266
    /data/src/github.com/openshift/origin/_output/local/go/src/github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/client/restclient/request.go:#27640,#27764 /data/src/github.com/openshift/origin/_output/local/go/src/github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/client/restclient/request.go:#27685,#27704
[INFO] Full output from `go test` logged at /tmp/openshift/test-go/logs/test-go.log

[soltysh]

OMG, I'm getting old 😊

[sjenning]

I hit this flake as well in #10305 here

Golang upstream bug golang/go#16540

[sjenning]

This is the problematic line
https://github.com/openshift/origin/blob/master/vendor/k8s.io/kubernetes/pkg/client/restclient/request.go#L898

Involves a go tool cover bug regarding function literals in switch case statements.

[ncdc]

This actually isn't a problem as it doesn't cause the test to return nonzero. Reopen if you find otherwise.

[ncdc]

Jenkins job 4739 actually failed because of this (from test-go.log):

--- PASS: TestDelete (0.56s)
PASS
coverage: 72.7% of statements
ok      github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/registry/event/etcd    2.844s  coverage: 72.7% of statements
chdir /data/src/github.com/openshift/origin/_output/local/go/src/github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/registry/experimental/controller/etcd: no such file or directory
FAIL    github.com/openshift/origin/vendor/k8s.io/kubernetes/pkg/registry/experimental/controller/etcd  0.000s

cc @stevekuznetsov

[stevekuznetsov]

@ncdc the error you linked is in fact a manifestation of #9457, unless the files were really missing