build status update extended tests flaking

[bparees]

Both the "failed to pull builder image" and "failed to fetch source" tests are flaking regularly:

[Fail] [builds][Slow] update failure status Build status Docker fetch source failure [It] should contain the Docker build fetch source failure reason and message 
/data/src/github.com/openshift/origin/test/extended/builds/failure_status.go:67

[Fail] [builds][Slow] update failure status Build status fetch S2I source failure [It] should contain the S2I fetch source failure reason and message 
/data/src/github.com/openshift/origin/test/extended/builds/failure_status.go:84

[Fail] [builds][Slow] update failure status Build status fetch builder image failure [It] should contain the fetch builder image failure reason and message 
/data/src/github.com/openshift/origin/test/extended/builds/failure_status.go:101

as seen in https://ci.openshift.redhat.com/jenkins/job/origin_extended_build_tests/884

In the case of the fetch builder image failure, the build log shows the failure did occur, but it seems like either the build didn't get updated, or wasn't updated fast enough for the test to see it:

2016-12-24T08:43:40.536523000Z Pulling image fail/me ...
2016-12-24T08:43:40.538281000Z Trying to pull repository docker.io/fail/me ... 
2016-12-24T08:43:40.583666000Z Pulling repository docker.io/fail/me
2016-12-24T08:43:40.641705000Z Error: image fail/me not found
2016-12-24T08:43:40.649884000Z F1224 08:43:40.649507       1 helpers.go:115] error: build error: failed to pull image: Error: image fail/me not found

The fetch source failure also appears to have properly failed but not updated the build status:

2016-12-24T08:49:53.167059000Z I1224 08:49:53.162810       1 repository.go:435] Error executing command: exit status 128
2016-12-24T08:49:53.167307000Z I1224 08:49:53.162893       1 source.go:129] fatal: unable to access 'https://failure/docker/status/': Could not resolve host: failure; Unknown error
2016-12-24T08:49:53.203083000Z F1224 08:49:53.202400       1 helpers.go:115] error: build error: fatal: unable to access 'https://failure/docker/status/': Could not resolve host: failure; Unknown error

@PI-Victor We need more logging around the code that updates the build status.

[PI-Victor]

i always thought there might be a race condition while updating the buildobject :-< and i think this confirms it. will try to add some debugging for the logs.

[bparees]

i always thought there might be a race condition while updating the buildobject :-< and i think this confirms it. will try to add some debugging for the logs.

thanks :/

[bparees]

presumably the same cause as https://bugzilla.redhat.com/show_bug.cgi?id=1415946 so assigning to @coreydaley