Skip to content

RBAC Migration Followup #2: Gating tests #15814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
enj opened this issue Aug 17, 2017 · 2 comments
Closed

RBAC Migration Followup #2: Gating tests #15814

enj opened this issue Aug 17, 2017 · 2 comments
Assignees
@simo5
Labels
area/security area/techdebt component/auth help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. priority/P2 sig/security
Milestone
v3.7

Comments

@enj
Copy link
Contributor

enj commented Aug 17, 2017 •
edited
Loading

hack/test-cmd.sh of gated overwrite bootstrap policy, create policy binding, and migrate authorization
@simo5 simo5 mentioned this issue Aug 17, 2017
Merged
67 tasks
@enj enj changed the title RBAC Migration Followup #2: Gating RBAC Migration Followup #2: Gating tests Aug 17, 2017
@enj enj modified the milestone: 3.7.0 Aug 17, 2017
@simo5 simo5 added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Aug 22, 2017
@enj
Copy link
Contributor Author

enj commented Aug 25, 2017

There are three callers of pkg/cmd/util/clientcmd/gating.go. Running any of these commands on master should result in an error saying that it does not support the current server version. We should add some shell based tests to make sure that this is true for all the gated commands. See os::cmd::expect_failure_and_text for examples.

@enj
Copy link
Contributor Author

enj commented Sep 18, 2017

Fixed in #16219

@enj enj closed this as completed Sep 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simo5 simo5

Labels
area/security area/techdebt component/auth help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. priority/P2 sig/security
Projects
None yet
Milestone
v3.7
Development

No branches or pull requests
2 participants
@enj @simo5