OCM-14136 | feat: Add UX informational msgs when create/nodepool

Author: hunterkepley

cmd/describe/autoscaler/cmd.go

@@ -62,7 +62,11 @@ func DescribeAutoscalerRunner() rosa.CommandRunner {
 		if output.HasFlag() {
 			output.Print(autoscaler)
 		} else {
-			fmt.Print(clusterautoscaler.PrintAutoscaler(autoscaler))
+			if cluster.Hypershift().Enabled() {
+				fmt.Print(clusterautoscaler.PrintHypershiftAutoscaler(autoscaler))
+			} else {
+				fmt.Print(clusterautoscaler.PrintAutoscaler(autoscaler))
+			}
 		}
 		return nil
 	}

pkg/clusterautoscaler/output.go

@@ -87,3 +87,25 @@ func PrintAutoscaler(a *cmv1.ClusterAutoscaler) string {
 
 	return out
 }
+
+func PrintHypershiftAutoscaler(a *cmv1.ClusterAutoscaler) string {
+
+	out := "\n"
+
+	if a.MaxNodeProvisionTime() != "" {
+		out += fmt.Sprintf("Maximum Node Provision Time:               %s\n",
+			a.MaxNodeProvisionTime())
+	}
+
+	out += fmt.Sprintf("Maximum Pod Grace Period:                  %d\n",
+		a.MaxPodGracePeriod())
+	out += fmt.Sprintf("Pod Priority Threshold:                    %d\n",
+		a.PodPriorityThreshold())
+
+	//Resource Limits
+	out += "Resource Limits:\n"
+	out += fmt.Sprintf(" - Maximum Nodes:                          %d\n",
+		a.ResourceLimits().MaxNodesTotal())
+
+	return out
+}

pkg/machinepool/helper.go

@@ -21,6 +21,10 @@ import (
 	"github.com/openshift/rosa/pkg/rosa"
 )
 
+const (
+	hcpMaxNodesLimit = 500
+)
+
 type ReplicaSizeValidation struct {
 	MinReplicas         int
 	ClusterVersion      string
@@ -316,7 +320,6 @@ func getSubnetFromAvailabilityZone(cmd *cobra.Command, r *rosa.Runtime, isAvaila
 
 // temporary fn until calculated default values can be retrieved from single source of truth
 func validateClusterVersionWithMaxNodesLimit(clusterVersion string, replicas int, isHostedCp bool) error {
-	hcpMaxNodesLimit := 500
 	if isHostedCp {
 		if replicas > hcpMaxNodesLimit {
 			return fmt.Errorf("should provide an integer number less than or equal to '%v'", hcpMaxNodesLimit)

pkg/machinepool/machinepool.go

@@ -34,6 +34,10 @@ import (
 	"github.com/openshift/rosa/pkg/rosa"
 )
 
+const (
+	clusterAutoscalerLimitMessage = "Cluster Autoscaler limit (MaxNodes)"
+)
+
 var fetchMessage string = "Fetching %s '%s' for cluster '%s'"
 var notFoundMessage string = "Machine pool '%s' not found"
 
@@ -948,6 +952,43 @@ func (m *machinePool) CreateNodePools(r *rosa.Runtime, cmd *cobra.Command, clust
 		}
 	}
 
+	sumOfReplicas := replicas
+	sumOfMaxReplicas := maxReplicas
+	sumOfMinReplicas := minReplicas
+
+	for _, np := range cluster.NodePools().Items() {
+		// If autoscaling, calculate min and max, use min and max in separate messages below
+		autoscaling, ok := np.GetAutoscaling()
+		if !ok || autoscaling == nil {
+			npReplicas, ok := np.GetReplicas()
+			if !ok {
+				return fmt.Errorf("Failed to get node pool replicas for hosted cluster '%s': %v", clusterKey, err)
+			}
+			sumOfReplicas += npReplicas
+		} else {
+			sumOfMaxReplicas += autoscaling.MaxReplica()
+			sumOfMinReplicas += autoscaling.MinReplica()
+		}
+	}
+
+	// Informational message for cluster autoscaler + scaling out to max nodes
+	if autoscaling {
+		r.Reporter.Infof("Scaling max replicas to the maximum allowed value is subject to cluster autoscaler" +
+			" configuration")
+	}
+
+	// Informational message for sum of replicas > MaxNodesTotal
+	if sumOfReplicas+sumOfMaxReplicas > hcpMaxNodesLimit {
+		r.Reporter.Infof("Actual maximum replicas can be lowered, since the replicas defined exceeds "+
+			"%s", clusterAutoscalerLimitMessage)
+	}
+
+	// Informational message for min-replicas or replicas > MaxNodesTotal
+	if sumOfReplicas+sumOfMinReplicas > hcpMaxNodesLimit {
+		r.Reporter.Infof("Actual total nodes in the cluster will be more than the maximum nodes configured " +
+			"in the cluster autoscaler")
+	}
+
 	if version != "" {
 		npBuilder.Version(cmv1.NewVersion().ID(version))
 	}
@@ -1776,6 +1817,43 @@ func editNodePool(cmd *cobra.Command, nodePoolID string,
 		}
 	}
 
+	sumOfReplicas := replicas
+	sumOfMaxReplicas := maxReplicas
+	sumOfMinReplicas := minReplicas
+
+	for _, np := range cluster.NodePools().Items() {
+		// If autoscaling, calculate min and max, use min and max in separate messages below
+		autoscaling, ok := np.GetAutoscaling()
+		if !ok || autoscaling == nil {
+			npReplicas, ok := np.GetReplicas()
+			if !ok {
+				return fmt.Errorf("Failed to get node pool replicas for hosted cluster '%s': %v", clusterKey, err)
+			}
+			sumOfReplicas += npReplicas
+		} else {
+			sumOfMaxReplicas += autoscaling.MaxReplica()
+			sumOfMinReplicas += autoscaling.MinReplica()
+		}
+	}
+
+	// Informational message for cluster autoscaler + scaling out to max nodes
+	if autoscaling {
+		r.Reporter.Infof("Scaling max replicas to the maximum allowed value is subject to cluster autoscaler" +
+			" configuration")
+	}
+
+	// Informational message for sum of replicas > MaxNodesTotal
+	if sumOfReplicas+sumOfMaxReplicas > hcpMaxNodesLimit {
+		r.Reporter.Infof("Actual maximum replicas can be lowered, since the replicas defined exceeds "+
+			"%s", clusterAutoscalerLimitMessage)
+	}
+
+	// Informational message for min-replicas or replicas > MaxNodesTotal
+	if sumOfReplicas+sumOfMinReplicas > hcpMaxNodesLimit {
+		r.Reporter.Infof("Actual total nodes in the cluster will be more than the maximum nodes configured " +
+			"in the cluster autoscaler")
+	}
+
 	update, err := npBuilder.Build()
 	if err != nil {
 		return fmt.Errorf("Failed to create machine pool for hosted cluster '%s': %v", clusterKey, err)