OCM-13048 | fix: Output formatting for deleting account roles

hunterkepley · hunterkepley · commit c7a9e8dffcdd · 2024-12-11T11:37:20.000-05:00
diff --git a/cmd/dlt/accountroles/cmd.go b/cmd/dlt/accountroles/cmd.go
@@ -238,9 +238,8 @@ func deleteAccountRoles(r *rosa.Runtime, cmd *cobra.Command, env string, prefix
 				r.Reporter.Warnf("There was an error deleting the account roles or policies: %s", err)
 				continue
 			}
-
-			r.Reporter.Infof(fmt.Sprintf("Successfully deleted the %s account roles", roleTypeString))
 		}
+		r.Reporter.Infof(fmt.Sprintf("Successfully deleted the %saccount roles", roleTypeString))
 	case interactive.ModeManual:
 		r.OCMClient.LogEvent("ROSADeleteAccountRoleModeManual", nil)
 		policyMap, arbitraryPolicyMap, err := r.AWSClient.GetAccountRolePolicies(finalRoleList, prefix)

Original file line number	Diff line number	Diff line change
`@@ -238,9 +238,8 @@ func deleteAccountRoles(r rosa.Runtime, cmd cobra.Command, env string, prefix`
`238`	`238`	`r.Reporter.Warnf("There was an error deleting the account roles or policies: %s", err)`
`239`	`239`	`continue`
`240`	`240`	`}`
`241`		`-`
`242`		`- r.Reporter.Infof(fmt.Sprintf("Successfully deleted the %s account roles", roleTypeString))`
`243`	`241`	`}`
	`242`	`+ r.Reporter.Infof(fmt.Sprintf("Successfully deleted the %saccount roles", roleTypeString))`
`244`	`243`	`case interactive.ModeManual:`
`245`	`244`	`r.OCMClient.LogEvent("ROSADeleteAccountRoleModeManual", nil)`
`246`	`245`	`policyMap, arbitraryPolicyMap, err := r.AWSClient.GetAccountRolePolicies(finalRoleList, prefix)`