Remove LLVM_ABI_BREAKING_CHECKS=FORCE_OFF.

karupayun · chsigg · commit c34395c204c3 · 2024-10-07T11:30:43.000+02:00
The issue raised in triton-lang#4212 (comment) and temporary fixed in triton-lang#4512 has now been fixed upstream. The non-deterministic seed inside the hashing function (included in this llvm commit: llvm/llvm-project@ce80c80) was disabled for clang <= 11 for non-pic builds. This was removed again in xgupta/llvm-project@5255b81 and we can enable ABI-breaking checks again. We build LLVM with PIC. If anyone ever builds with non-PIC, they will get a compilation error and need to disable LLVM_ABI_BREAKING_CHECKS manually.
diff --git a/.github/workflows/llvm-build/almalinux.Dockerfile b/.github/workflows/llvm-build/almalinux.Dockerfile
@@ -33,7 +33,6 @@ RUN cmake -GNinja -Bbuild \
   -DLLVM_ENABLE_PROJECTS=mlir \
   -DLLVM_ENABLE_TERMINFO=OFF \
   -DLLVM_INSTALL_UTILS=ON \
-  -DLLVM_ABI_BREAKING_CHECKS=FORCE_OFF \
   -DLLVM_TARGETS_TO_BUILD="host;NVPTX;AMDGPU" \
   /source/llvm-project/llvm
 
diff --git a/cmake/llvm-hash.txt b/cmake/llvm-hash.txt
@@ -1 +1 @@
-61f8a7f618901797ee8663389a29722f29216a96
+5255b819c1b117e6048f354c035f5d36f3afad2b

Original file line number	Diff line number	Diff line change
`@@ -1 +1 @@`
`1`		`-61f8a7f618901797ee8663389a29722f29216a96`
	`1`	`+5255b819c1b117e6048f354c035f5d36f3afad2b`