Skip to content

Commit 1e1d748

Browse files
amotinbehlendorf
authored andcommitted
ZIL: Remove 128K into 2x68K LWB split optimization
To improve 128KB block write performance in case of multiple VDEVs ZIL used to spit those writes into two 64KB ones. Unfortunately it was found to cause LWB buffer overflow, trying to write maximum- sizes 128KB TX_CLONE_RANGE record with 1022 block pointers into 68KB buffer, since unlike TX_WRITE ZIL code can't split it. This is a minimally-invasive temporary block cloning fix until the following more invasive prediction code refactoring. Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: Ameer Hamza <[email protected]> Signed-off-by: Alexander Motin <[email protected]> Sponsored by: iXsystems, Inc. Closes #15634
1 parent dea2d3c commit 1e1d748

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

module/zfs/zil.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1733,8 +1733,6 @@ static const struct {
17331733
{ 8192 + 4096, 8192 + 4096 }, /* database */
17341734
{ 32768 + 4096, 32768 + 4096 }, /* NFS writes */
17351735
{ 65536 + 4096, 65536 + 4096 }, /* 64KB writes */
1736-
{ 131072, 131072 }, /* < 128KB writes */
1737-
{ 131072 +4096, 65536 + 4096 }, /* 128KB writes */
17381736
{ UINT64_MAX, SPA_OLD_MAXBLOCKSIZE}, /* > 128KB writes */
17391737
};
17401738

0 commit comments

Comments
 (0)