Skip to content

Commit c8aed9f

Browse files
UglymothaSietse
andauthored
Verify parent_dev before calling udev_device_get_sysattr_value
Not all udev devices have parent devices. Calling udev_device_get_ functions yield an assertion error if called with a NULL pointer. Reviewed-by: Brian Behlendorf <[email protected]> Reviewed-by: Alexander Motin <[email protected]> Signed-off-by: Sietse <[email protected]> Co-authored-by: Sietse <[email protected]> Closes #16705 Closes #16717
1 parent b16e096 commit c8aed9f

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

cmd/zed/zed_disk_event.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,8 @@ dev_event_nvlist(struct udev_device *dev)
139139
* is /dev/sda.
140140
*/
141141
struct udev_device *parent_dev = udev_device_get_parent(dev);
142-
if ((value = udev_device_get_sysattr_value(parent_dev, "size"))
142+
if (parent_dev != NULL &&
143+
(value = udev_device_get_sysattr_value(parent_dev, "size"))
143144
!= NULL) {
144145
uint64_t numval = DEV_BSIZE;
145146

0 commit comments

Comments
 (0)