Tinker with slop space accounting with dedup

rincebrain · rincebrain · commit d7872e970e71 · 2021-06-23T12:33:28.000-04:00
Let's not include the deduplicated space usage in the slop space
reservation, it leads to surprising outcomes.

Signed-off-by: Rich Ercolani &lt;rincebrain@gmail.com&gt;
diff --git a/module/zfs/spa_misc.c b/module/zfs/spa_misc.c
@@ -1798,7 +1798,7 @@ spa_get_worst_case_asize(spa_t *spa, uint64_t lsize)
 uint64_t
 spa_get_slop_space(spa_t *spa)
 {
-	uint64_t space = spa_get_dspace(spa);
+	uint64_t space = spa_get_dspace(spa) - spa->spa_dedup_dspace;
 	uint64_t slop = MIN(space >> spa_slop_shift, spa_max_slop);
 
 	/*

Original file line number	Diff line number	Diff line change
`@@ -1798,7 +1798,7 @@ spa_get_worst_case_asize(spa_t *spa, uint64_t lsize)`
`1798`	`1798`	`uint64_t`
`1799`	`1799`	`spa_get_slop_space(spa_t *spa)`
`1800`	`1800`	`{`
`1801`		`- uint64_t space = spa_get_dspace(spa);`
	`1801`	`+ uint64_t space = spa_get_dspace(spa) - spa->spa_dedup_dspace;`
`1802`	`1802`	`uint64_t slop = MIN(space >> spa_slop_shift, spa_max_slop);`
`1803`	`1803`
`1804`	`1804`	`/*`