Skip to content

Commit 2d78434

Browse files
authored
ZTS: zdb_block_size_histogram increase variance
The expected variance for this test case was originally set at 10% based on local testing. Additional testing via the CI has show it can be as large as 11%. Increase the expected maximum to 12% to prevent this test from incorrectly failing. Reviewed-by: Ryan Moeller <[email protected]> Reviewed-by: George Melikov <[email protected]> Signed-off-by: Brian Behlendorf <[email protected]> Closes openzfs#11148
1 parent 123d280 commit 2d78434

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

tests/zfs-tests/tests/functional/cli_root/zdb/zdb_block_size_histogram.ksh

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -209,11 +209,11 @@ function histo_check_test_pool
209209
# 4096 blocksize count for asize. For verification we stick
210210
# to just lsize counts.
211211
#
212-
# The max_variance is hard-coded here at 10%. testing so far
213-
# has shown this to be in the range of 2%-8% so we leave a
214-
# generous allowance... This might need changes in the future
212+
# The max_variance is hard-coded here at 12% to leave us some
213+
# margin. Testing has shown this normally to be in the range
214+
# of 2%-8%, but it may be as large as 11%.
215215
###################
216-
let max_variance=10
216+
let max_variance=12
217217
let fail_value=0
218218
let error_count=0
219219
log_note "Comparisons for ${pool}"

0 commit comments

Comments
 (0)