fix: sonar issues

Author: metacosm

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/DefaultControllerConfiguration.java

@@ -21,9 +21,10 @@ public class DefaultControllerConfiguration<R extends HasMetadata>
   private final String labelSelector;
   private final ResourceEventFilter<R> resourceEventFilter;
   private final Class<R> resourceClass;
-  private final List<? extends DependentResource> dependents;
+  private final List<DependentResource> dependents;
   private ConfigurationService service;
 
+  // NOSONAR constructor is meant to provide all information
   public DefaultControllerConfiguration(
       String associatedControllerClassName,
       String name,
@@ -36,7 +37,7 @@ public DefaultControllerConfiguration(
       ResourceEventFilter<R> resourceEventFilter,
       Class<R> resourceClass,
       ConfigurationService service,
-      List<? extends DependentResource> dependents) {
+      List<DependentResource> dependents) {
     this.associatedControllerClassName = associatedControllerClassName;
     this.name = name;
     this.crdName = crdName;
@@ -106,7 +107,7 @@ public ConfigurationService getConfigurationService() {
   @Override
   public void setConfigurationService(ConfigurationService service) {
     if (this.service != null) {
-      throw new RuntimeException("A ConfigurationService is already associated with '" + name
+      throw new IllegalStateException("A ConfigurationService is already associated with '" + name
           + "' ControllerConfiguration. Cannot change it once set!");
     }
     this.service = service;
@@ -128,7 +129,7 @@ public ResourceEventFilter<R> getEventFilter() {
   }
 
   @Override
-  public List<? extends DependentResource> getDependentResources() {
+  public List<DependentResource> getDependentResources() {
     return dependents;
   }
 }

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/reconciler/dependent/DependentResourceController.java

@@ -16,6 +16,7 @@ public class DependentResourceController<R, P extends HasMetadata>
   private final Persister<R, P> persister;
   private final DependentResource<R, P> delegate;
 
+  @SuppressWarnings("unchecked")
   public DependentResourceController(DependentResource<R, P> delegate) {
     this.delegate = delegate;
     builder = (delegate instanceof Builder) ? (Builder<R, P>) delegate : null;
@@ -24,6 +25,7 @@ public DependentResourceController(DependentResource<R, P> delegate) {
     persister = initPersister(delegate);
   }
 
+  @SuppressWarnings("unchecked")
   protected Persister<R, P> initPersister(DependentResource<R, P> delegate) {
     if (delegate instanceof Persister) {
       return (Persister<R, P>) delegate;
@@ -56,6 +58,7 @@ public Class<R> getResourceType() {
     return delegate.resourceType();
   }
 
+  @Override
   public EventSource initEventSource(EventSourceContext<P> context) {
     return delegate.initEventSource(context);
   }

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/Controller.java

@@ -39,6 +39,7 @@
 import io.javaoperatorsdk.operator.processing.event.EventSourceManager;
 import io.javaoperatorsdk.operator.processing.event.source.EventSource;
 
+@SuppressWarnings({"rawtypes", "unchecked"})
 public class Controller<R extends HasMetadata> implements Reconciler<R>,
     LifecycleAware, EventSourceInitializer<R> {
 
@@ -49,8 +50,8 @@ public class Controller<R extends HasMetadata> implements Reconciler<R>,
   private final KubernetesClient kubernetesClient;
   private final AtomicBoolean started = new AtomicBoolean(false);
   private List<DependentResourceController> dependents;
-  private EventSourceManager<R> eventSourceManager;
-  private volatile ConfigurationService configurationService;
+  private final EventSourceManager<R> eventSourceManager;
+  private ConfigurationService configurationService;
 
   public Controller(Reconciler<R> reconciler,
       ControllerConfiguration<R> configuration,
@@ -220,7 +221,7 @@ private Metrics metrics() {
 
   @Override
   public List<EventSource> prepareEventSources(EventSourceContext<R> context) {
-    final List<? extends DependentResource> configured = configuration.getDependentResources();
+    final List<DependentResource> configured = configuration.getDependentResources();
     dependents = new ArrayList<>(configured.size());
 
     List<EventSource> sources = new ArrayList<>(configured.size() + 5);

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/EventSourceManager.java

@@ -86,13 +86,15 @@ public void start() {
     }
   }
 
+  @SuppressWarnings("rawtypes")
   private void logEventSourceEvent(EventSource eventSource, String event) {
     if (log.isDebugEnabled()) {
       if (eventSource instanceof ResourceEventSource) {
         ResourceEventSource source = (ResourceEventSource) eventSource;
-        log.debug(event + " event source {} for {}", eventSource.name(), source.getResourceClass());
+        log.debug("{} event source {} for {}", event, eventSource.name(),
+            source.getResourceClass());
       } else {
-        log.debug(event + " event source {}", eventSource.name());
+        log.debug("{} event source {}", event, eventSource.name());
       }
     }
   }
@@ -126,7 +128,7 @@ public final void registerEventSource(EventSource eventSource)
       eventSource.setEventHandler(eventProcessor);
     } catch (IllegalStateException | MissingCRDException e) {
       throw e; // leave untouched
-    } catch (Throwable e) {
+    } catch (Exception e) {
       throw new OperatorException("Couldn't register event source: " + eventSource.name(), e);
     } finally {
       lock.unlock();
@@ -234,7 +236,7 @@ public void add(EventSource eventSource) {
       sources.computeIfAbsent(keyFor(eventSource), k -> new ArrayList<>()).add(eventSource);
     }
 
-    private Class getDependentType(EventSource source) {
+    private Class<?> getDependentType(EventSource source) {
       return source instanceof ResourceEventSource
           ? ((ResourceEventSource) source).getResourceClass()
           : source.getClass();

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/source/AbstractEventSource.java

@@ -5,7 +5,7 @@
 
 public abstract class AbstractEventSource implements EventSource {
 
-  private volatile EventHandler handler;
+  private EventHandler handler;
   private volatile boolean running = false;
 
   protected EventHandler getEventHandler() {

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/source/CachingEventSource.java

@@ -27,7 +27,7 @@ public abstract class CachingEventSource<T, P extends HasMetadata>
 
   protected UpdatableCache<T> cache;
 
-  public CachingEventSource(Class<T> resourceClass) {
+  protected CachingEventSource(Class<T> resourceClass) {
     super(resourceClass);
     cache = initCache();
   }

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/source/informer/InformerEventSource.java

@@ -97,6 +97,7 @@ public void stop() {
    * @param resource the primary resource we want to retrieve the associated resource for
    * @return the informed resource associated with the specified primary resource
    */
+  @Override
   public Optional<T> getAssociated(P resource) {
     final var id = configuration.getAssociatedResourceIdentifier().associatedSecondaryID(resource);
     return get(id);

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/source/informer/InformerManager.java

@@ -21,7 +21,6 @@
 import io.javaoperatorsdk.operator.api.config.ResourceConfiguration;
 import io.javaoperatorsdk.operator.processing.LifecycleAware;
 import io.javaoperatorsdk.operator.processing.event.ResourceID;
-import io.javaoperatorsdk.operator.processing.event.source.AbstractResourceEventSource;
 import io.javaoperatorsdk.operator.processing.event.source.Cache;
 import io.javaoperatorsdk.operator.processing.event.source.ResourceCache;
 import io.javaoperatorsdk.operator.processing.event.source.UpdatableCache;
@@ -30,7 +29,7 @@ public class InformerManager<T extends HasMetadata, C extends ResourceConfigurat
     implements LifecycleAware, ResourceCache<T>, UpdatableCache<T> {
 
   private static final String ANY_NAMESPACE_MAP_KEY = "anyNamespace";
-  private static final Logger log = LoggerFactory.getLogger(AbstractResourceEventSource.class);
+  private static final Logger log = LoggerFactory.getLogger(InformerManager.class);
 
   private final Map<String, InformerWrapper<T>> sources = new ConcurrentHashMap<>();
   private Cloner cloner;

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/source/informer/ManagedInformerEventSource.java

@@ -13,7 +13,7 @@ public abstract class ManagedInformerEventSource<R extends HasMetadata, P extend
     extends CachingEventSource<R, P>
     implements ResourceEventHandler<R> {
 
-  public ManagedInformerEventSource(
+  protected ManagedInformerEventSource(
       MixedOperation<R, KubernetesResourceList<R>, Resource<R>> client, C configuration) {
     super(configuration.getResourceClass());
     manager().initSources(client, configuration, this);

operator-framework/src/main/java/io/javaoperatorsdk/operator/config/runtime/AnnotationConfiguration.java

@@ -13,7 +13,6 @@
 import io.javaoperatorsdk.operator.api.config.Dependent;
 import io.javaoperatorsdk.operator.api.config.DependentResource;
 import io.javaoperatorsdk.operator.api.config.KubernetesDependent;
-import io.javaoperatorsdk.operator.api.reconciler.Constants;
 import io.javaoperatorsdk.operator.api.reconciler.ControllerConfiguration;
 import io.javaoperatorsdk.operator.api.reconciler.Reconciler;
 import io.javaoperatorsdk.operator.api.reconciler.dependent.KubernetesDependentResourceController;
@@ -121,7 +120,7 @@ public ResourceEventFilter<R> getEventFilter() {
   }
 
   @Override
-  public List<? extends DependentResource> getDependentResources() {
+  public List<DependentResource> getDependentResources() {
     if (dependents == null) {
       final var dependentConfigs = valueOrDefault(annotation,
           ControllerConfiguration::dependents, new Dependent[] {});