Skip to content

Commit aadba2b

Browse files
committed
refactor: remove configurationService method
1 parent 40d9124 commit aadba2b

File tree

1 file changed

+2
-7
lines changed
  • operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing

1 file changed

+2
-7
lines changed

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/Controller.java

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616
import io.javaoperatorsdk.operator.CustomResourceUtils;
1717
import io.javaoperatorsdk.operator.MissingCRDException;
1818
import io.javaoperatorsdk.operator.OperatorException;
19-
import io.javaoperatorsdk.operator.api.config.ConfigurationService;
2019
import io.javaoperatorsdk.operator.api.config.ConfigurationServiceProvider;
2120
import io.javaoperatorsdk.operator.api.config.ControllerConfiguration;
2221
import io.javaoperatorsdk.operator.api.monitoring.Metrics;
@@ -122,7 +121,7 @@ public UpdateControl<P> execute() {
122121

123122

124123
private Metrics metrics() {
125-
final var metrics = configurationService().getMetrics();
124+
final var metrics = ConfigurationServiceProvider.instance().getMetrics();
126125
return metrics != null ? metrics : Metrics.NOOP;
127126
}
128127

@@ -199,7 +198,7 @@ public void start() throws OperatorException {
199198
try {
200199
// check that the custom resource is known by the cluster if configured that way
201200
final CustomResourceDefinition crd; // todo: check proper CRD spec version based on config
202-
if (configurationService().checkCRDAndValidateLocalModel()
201+
if (ConfigurationServiceProvider.instance().checkCRDAndValidateLocalModel()
203202
&& CustomResource.class.isAssignableFrom(resClass)) {
204203
crd = kubernetesClient.apiextensions().v1().customResourceDefinitions().withName(crdName)
205204
.get();
@@ -224,10 +223,6 @@ public void start() throws OperatorException {
224223
}
225224
}
226225

227-
private ConfigurationService configurationService() {
228-
return ConfigurationServiceProvider.instance();
229-
}
230-
231226
private void throwMissingCRDException(String crdName, String specVersion, String controllerName) {
232227
throw new MissingCRDException(
233228
crdName,

0 commit comments

Comments
 (0)