fix: startup bug, when CRs already present on cluster + renaming (#677)

* chore(deps): upgrade to fabric8 5.10.1 (#656)

Mocking the version is not needed anymore.

(cherry picked from commit f3b9438)

* fix: startup bug, when CRs already present on cluster + renaming

* feat: pass selector as String instead of parsing it

This is a new feature of Fabric8 5.9+

Co-authored-by: Chris Laprun <[email protected]>

Author: csviri

operator-framework-core/src/main/java/io/javaoperatorsdk/operator/processing/event/internal/CustomResourceEventSource.java

@@ -6,8 +6,10 @@
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
+import io.fabric8.kubernetes.api.model.KubernetesResourceList;
 import io.fabric8.kubernetes.client.CustomResource;
 import io.fabric8.kubernetes.client.KubernetesClientException;
+import io.fabric8.kubernetes.client.dsl.FilterWatchListDeletable;
 import io.fabric8.kubernetes.client.informers.ResourceEventHandler;
 import io.fabric8.kubernetes.client.informers.SharedIndexInformer;
 import io.fabric8.kubernetes.client.informers.cache.Cache;
@@ -23,7 +25,6 @@
 import static io.javaoperatorsdk.operator.processing.KubernetesResourceUtils.getName;
 import static io.javaoperatorsdk.operator.processing.KubernetesResourceUtils.getUID;
 import static io.javaoperatorsdk.operator.processing.KubernetesResourceUtils.getVersion;
-import static io.javaoperatorsdk.operator.processing.event.internal.LabelSelectorParser.parseSimpleLabelSelector;
 
 /**
  * This is a special case since is not bound to a single custom resource
@@ -74,16 +75,16 @@ public void start() {
 
     try {
       if (ControllerConfiguration.allNamespacesWatched(targetNamespaces)) {
-        var informer = client.inAnyNamespace()
-            .withLabels(parseSimpleLabelSelector(labelSelector)).inform(this);
-        sharedIndexInformers.put(ANY_NAMESPACE_MAP_KEY, informer);
+        final var filteredBySelectorClient = client.inAnyNamespace()
+            .withLabelSelector(labelSelector);
+        final var informer =
+            createAndRunInformerFor(filteredBySelectorClient, ANY_NAMESPACE_MAP_KEY);
         log.debug("Registered {} -> {} for any namespace", controller, informer);
       } else {
         targetNamespaces.forEach(
             ns -> {
-              var informer = client.inNamespace(ns)
-                  .withLabels(parseSimpleLabelSelector(labelSelector)).inform(this);
-              sharedIndexInformers.put(ns, informer);
+              final var informer = createAndRunInformerFor(
+                  client.inNamespace(ns).withLabelSelector(labelSelector), ns);
               log.debug("Registered {} -> {} for namespace: {}", controller, informer,
                   ns);
             });
@@ -103,6 +104,15 @@ public void start() {
     }
   }
 
+  private SharedIndexInformer<T> createAndRunInformerFor(
+      FilterWatchListDeletable<T, KubernetesResourceList<T>> filteredBySelectorClient, String key) {
+    var informer = filteredBySelectorClient.runnableInformer(0);
+    informer.addEventHandler(this);
+    sharedIndexInformers.put(key, informer);
+    informer.run();
+    return informer;
+  }
+
   @Override
   public void stop() {
     for (SharedIndexInformer<T> informer : sharedIndexInformers.values()) {

operator-framework-core/src/test/java/io/javaoperatorsdk/operator/processing/event/internal/LabelSelectorParserTest.java

@@ -106,7 +106,7 @@ public String getNamespace() {
   }
 
   @SuppressWarnings({"rawtypes"})
-  public List<Reconciler> getControllers() {
+  public List<Reconciler> getReconcilers() {
     return operator.getControllers().stream()
         .map(Controller::getReconciler)
         .collect(Collectors.toUnmodifiableList());

operator-framework-junit5/src/main/java/io/javaoperatorsdk/operator/junit/OperatorExtension.java

@@ -58,6 +58,6 @@ public static void waitXms(int x) {
   }
 
   public static int getNumberOfExecutions(OperatorExtension extension) {
-    return ((TestExecutionInfoProvider) extension.getControllers().get(0)).getNumberOfExecutions();
+    return ((TestExecutionInfoProvider) extension.getReconcilers().get(0)).getNumberOfExecutions();
   }
 }