Skip to content

Remove automated observed generation handling? #2329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
csviri opened this issue Apr 3, 2024 · 2 comments · Fixed by #2382
Closed

Remove automated observed generation handling? #2329

csviri opened this issue Apr 3, 2024 · 2 comments · Fixed by #2382
Milestone
5.0

Comments

@csviri
Copy link
Collaborator

csviri commented Apr 3, 2024 •
edited
Loading

With SSA handling this required UpdateControl.patchStatus or UpdateControl.patchResourceAndStatus to be called. Which is much less transparent now.

This feature is also not that useful / can be done easily manually. Also without it ReconcilierDispatcher implementation will be simpler.
@csviri csviri added this to the 5.0 milestone Apr 3, 2024
@metacosm
Copy link
Collaborator

metacosm commented Apr 3, 2024

How would things be handled without it?

@csviri
Copy link
Collaborator Author

csviri commented Apr 9, 2024

User would just set it in the reconciler.

@csviri csviri mentioned this issue Apr 16, 2024
Closed
@csviri csviri linked a pull request May 14, 2024 that will close this issue
feat: remove automatic observed generation handling #2382
Merged
@csviri csviri closed this as completed May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.0
Development

Successfully merging a pull request may close this issue.

feat: remove automatic observed generation handling operator-framework/java-operator-sdk
2 participants
@metacosm @csviri