Skip to content

Add API to re-schedule controller execution also for DeleteControl #571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
csviri opened this issue Sep 29, 2021 · 2 comments · Fixed by #600
Closed

Add API to re-schedule controller execution also for DeleteControl #571

csviri opened this issue Sep 29, 2021 · 2 comments · Fixed by #600
Assignees
Labels
api-changes-epic kind/feature Categorizes issue or PR as related to a new feature.
Milestone

Comments

@csviri
Copy link
Collaborator

csviri commented Sep 29, 2021

See the same for update control: #570
Delete control is now an enum so will need an API change.

@csviri csviri added this to the v2 milestone Sep 29, 2021
@jmrodri jmrodri added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 30, 2021
@cortex93
Copy link

cortex93 commented Oct 5, 2021

Is it for when deleteResource returns DeleteControl.NO_FINALIZER_REMOVAL, so the controler can decide to reconcile later (e.g. when a non transient error occured) ?

@csviri
Copy link
Collaborator Author

csviri commented Oct 5, 2021

@cortex93 usually its a special case. We had use cases when non-k8s resources were managed, and was waiting for events from those systems, while not all the external systems were cleaned up properly we returned NO_FINALIZER_REMOVAL so we don't block the Thread. In other words it's kinda for async cleanup usually for external systems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-changes-epic kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants