Skip to content

Add CSV finalizers to OLM #3143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tmshort opened this issue Jan 3, 2024 · 2 comments · Fixed by #3148
Closed

Add CSV finalizers to OLM #3143

tmshort opened this issue Jan 3, 2024 · 2 comments · Fixed by #3148
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@tmshort
Copy link
Contributor

tmshort commented Jan 3, 2024

Feature Request

Is your feature request related to a problem? Please describe.

See #3108 and corresponding discussion:
https://kubernetes.slack.com/archives/C0181L6JYQ2/p1704293361617039

With various performance improvements, the test case in #3108 started to fail more frequently, as the Subscription would re-create the CSV faster, subsequently blocking the CR/CRBs from being deleted, and thus causing the test to fail.

However, finalizers are not used (in general) for cleanup, and should be added.

Describe the solution you'd like
Add finalizers for appropriate deletion actions.

CSV Finalizer
For instance, the CSV needs a finalizer to cleanup CRs/CRBs.

Example Scenario:

  1. do all the normal setup
  2. scale the controller down to 0 replicas
  3. delete the CSV
  4. scale the controller up to 1 replicas

No cleanup will occur.

Other finalizers may also be necessary, but we want to ensure these are resolved.

@tmshort tmshort added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 3, 2024
@tmshort
Copy link
Contributor Author

tmshort commented Jan 3, 2024

See: #3130 (comment)

@tmshort
Copy link
Contributor Author

tmshort commented Jan 11, 2024

Moving InstallPlan finalizer to #3154

@tmshort tmshort changed the title Add finalizers to OLM Add CSV finalizers to OLM Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant