refactor: remove redundant package download

Signed-off-by: Amine <[email protected]>

Author: AmineRaouane

src/macaron/malware_analyzer/pypi_heuristics/metadata/fake_email.py

@@ -76,11 +76,6 @@ def analyze(self, pypi_package_json: PyPIPackageJsonAsset) -> tuple[HeuristicRes
         HeuristicAnalyzerValueError
             if the analysis fails.
         """
-        response = pypi_package_json.download("")
-        if not response:
-            error_message = "Failed to download package JSON "
-            return HeuristicResult.FAIL, {"message": error_message}
-
         data = pypi_package_json.package_json
         author_email = data.get("info", {}).get("author_email", None)
         maintainer_email = data.get("info", {}).get("maintainer_email", None)

tests/malware_analyzer/pypi/test_fake_email.py

@@ -46,17 +46,6 @@ def mock_dns_resolve_fixture() -> Generator[MagicMock]:
 
 
 # Tests for the analyze method
-def test_analyze_download_failure(analyzer: FakeEmailAnalyzer, pypi_package_json_asset_mock: MagicMock) -> None:
-    """Test the analyzer fails if downloading package JSON fails."""
-    pypi_package_json_asset_mock.download.return_value = False
-    result, info = analyzer.analyze(pypi_package_json_asset_mock)
-    assert result == HeuristicResult.FAIL
-    assert "message" in info
-    assert isinstance(info["message"], str)
-    assert "Failed to download package JSON" in info["message"]
-    pypi_package_json_asset_mock.download.assert_called_once_with("")
-
-
 def test_analyze_skip_no_emails_present(analyzer: FakeEmailAnalyzer, pypi_package_json_asset_mock: MagicMock) -> None:
     """Test the analyzer skips if no author_email or maintainer_email is present."""
     pypi_package_json_asset_mock.package_json = {"info": {"author_email": None, "maintainer_email": None}}