#patch: Issue with Snapshot.parse regex - ERROR: Found orphan snapshots (#177)

Author: rogervinas

java-snapshot-testing-core/src/main/java/au/com/origin/snapshots/Snapshot.java

@@ -29,7 +29,8 @@ public String getIdentifier() {
   }
 
   public static Snapshot parse(String rawText) {
-    String regex = "^(?<name>.*?)(\\[(?<scenario>.*)\\])?=(?<header>\\{.*?\\})?(?<snapshot>(.*)$)";
+    String regex =
+        "^(?<name>.*?)(\\[(?<scenario>[^]]*)])?=(?<header>\\{[^}]*?})?(?<snapshot>(.*)$)";
     Pattern p = Pattern.compile(regex, Pattern.DOTALL);
     Matcher m = p.matcher(rawText);
     boolean found = m.find();

java-snapshot-testing-core/src/test/java/au/com/origin/snapshots/SnapshotTest.java

@@ -0,0 +1,95 @@
+package au.com.origin.snapshots;
+
+import static org.assertj.core.api.Assertions.assertThat;
+import static org.assertj.core.api.Assertions.entry;
+
+import org.junit.jupiter.api.Test;
+
+class SnapshotTest {
+
+  @Test
+  public void shouldParseSnapshot() {
+    Snapshot snapshot =
+        Snapshot.parse(
+            Snapshot.builder().name("au.com.origin.snapshots.Test").body("body").build().raw());
+    assertThat(snapshot.getIdentifier()).isEqualTo("au.com.origin.snapshots.Test");
+    assertThat(snapshot.getName()).isEqualTo("au.com.origin.snapshots.Test");
+    assertThat(snapshot.getHeader()).isEmpty();
+    assertThat(snapshot.getScenario()).isBlank();
+    assertThat(snapshot.getBody()).isEqualTo("body");
+  }
+
+  @Test
+  public void shouldParseSnapshotWithHeaders() {
+    SnapshotHeader header = new SnapshotHeader();
+    header.put("header1", "value1");
+    Snapshot snapshot =
+        Snapshot.parse(
+            Snapshot.builder()
+                .name("au.com.origin.snapshots.Test")
+                .header(header)
+                .body("body")
+                .build()
+                .raw());
+    assertThat(snapshot.getIdentifier()).isEqualTo("au.com.origin.snapshots.Test");
+    assertThat(snapshot.getName()).isEqualTo("au.com.origin.snapshots.Test");
+    assertThat(snapshot.getHeader()).containsExactly(entry("header1", "value1"));
+    assertThat(snapshot.getScenario()).isBlank();
+    assertThat(snapshot.getBody()).isEqualTo("body");
+  }
+
+  @Test
+  public void shouldParseSnapshotWithScenario() {
+    Snapshot snapshot =
+        Snapshot.parse(
+            Snapshot.builder()
+                .name("au.com.origin.snapshots.Test")
+                .scenario("scenario")
+                .body("body")
+                .build()
+                .raw());
+    assertThat(snapshot.getIdentifier()).isEqualTo("au.com.origin.snapshots.Test[scenario]");
+    assertThat(snapshot.getName()).isEqualTo("au.com.origin.snapshots.Test");
+    assertThat(snapshot.getHeader()).isEmpty();
+    assertThat(snapshot.getScenario()).isEqualTo("scenario");
+    assertThat(snapshot.getBody()).isEqualTo("body");
+  }
+
+  @Test
+  public void shouldParseSnapshotWithScenarioAndHeaders() {
+    SnapshotHeader header = new SnapshotHeader();
+    header.put("header1", "value1");
+    Snapshot snapshot =
+        Snapshot.parse(
+            Snapshot.builder()
+                .name("au.com.origin.snapshots.Test")
+                .scenario("scenario")
+                .header(header)
+                .body("body")
+                .build()
+                .raw());
+    assertThat(snapshot.getIdentifier()).isEqualTo("au.com.origin.snapshots.Test[scenario]");
+    assertThat(snapshot.getName()).isEqualTo("au.com.origin.snapshots.Test");
+    assertThat(snapshot.getHeader()).containsExactly(entry("header1", "value1"));
+    assertThat(snapshot.getScenario()).isEqualTo("scenario");
+    assertThat(snapshot.getBody()).isEqualTo("body");
+  }
+
+  @Test
+  public void
+      shouldParseSnapshotWithScenarioAndBodyWithSomethingSimilarToAnScenarioToConfuseRegex() {
+    Snapshot snapshot =
+        Snapshot.parse(
+            Snapshot.builder()
+                .name("au.com.origin.snapshots.Test")
+                .scenario("scenario")
+                .body("[xxx]=yyy")
+                .build()
+                .raw());
+    assertThat(snapshot.getIdentifier()).isEqualTo("au.com.origin.snapshots.Test[scenario]");
+    assertThat(snapshot.getName()).isEqualTo("au.com.origin.snapshots.Test");
+    assertThat(snapshot.getHeader()).isEmpty();
+    assertThat(snapshot.getScenario()).isEqualTo("scenario");
+    assertThat(snapshot.getBody()).isEqualTo("[xxx]=yyy");
+  }
+}