Skip to content
This repository was archived by the owner on Feb 20, 2019. It is now read-only.

document new dependency tags in info.xml #706

Merged
merged 2 commits into from
Dec 26, 2014
Merged

Conversation

DeepDiver1975
Copy link
Contributor

@DeepDiver1975
Copy link
Contributor Author

closes #687

command
-------
Defines a command line tool to be available. With the attribute 'os' the required operating system for this tool can be
specified. Valid values for the 'os' attribute are as returned by the php function http://php.net/manual/en/function.php-uname.php
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The links needs to be in following format:

External hyperlinks, like `Python <http://www.python.org/>`_.

@MorrisJobke
Copy link
Contributor

Beside the mentioned link issue 👍

@BernhardPosselt
Copy link
Contributor

You may want to mention how the library names and versions are determined and mention the exceptions (e.g. libxml is called xml etc, the rest is queried using phpversion('libname'))

@BernhardPosselt
Copy link
Contributor

And maybe that http://php.net/manual/de/function.get-loaded-extensions.php is used for getting the extensions

@BernhardPosselt BernhardPosselt added this to the ownCloud 8 milestone Dec 15, 2014
@DeepDiver1975
Copy link
Contributor Author

@Raydiation more docs added - merge?


owncloud
--------
Defines minimum and maximum versions of the ownCloud core. In case undefined the values will be taken from the tag 'requiremin'.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In case of undefined -> In case no values are provided

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also requiremax and require i guess

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well - requiremax is not document and therefore to be ignored from my pov 🙊

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, yes makes sense

@BernhardPosselt
Copy link
Contributor

👍 if the above small comments are addressed :)

@carlaschroder
Copy link
Contributor

Is this for 8.0 only? Remember, master is 8.0 now.

@DeepDiver1975
Copy link
Contributor Author

Is this for 8.0 only? Remember, master is 8.0 now.

yes - oc8 only

BernhardPosselt pushed a commit that referenced this pull request Dec 26, 2014
document new dependency tags in info.xml
@BernhardPosselt BernhardPosselt merged commit 4359c37 into master Dec 26, 2014
@BernhardPosselt BernhardPosselt deleted the app-dependencies branch December 26, 2014 18:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants