Skip to content

Commit 5959a5b

Browse files
committed
test(editor): remove useless test + improve speed
1 parent e627309 commit 5959a5b

File tree

19 files changed

+4
-143
lines changed

19 files changed

+4
-143
lines changed

editors/vscode/fixtures/cross_module/.oxlintrc.json

Lines changed: 0 additions & 8 deletions
This file was deleted.

editors/vscode/fixtures/cross_module/debugger.ts

Lines changed: 0 additions & 2 deletions
This file was deleted.

editors/vscode/fixtures/cross_module/dep-a.ts

Lines changed: 0 additions & 4 deletions
This file was deleted.

editors/vscode/fixtures/cross_module/dep-b.ts

Lines changed: 0 additions & 4 deletions
This file was deleted.

editors/vscode/fixtures/cross_module_extended_config/.oxlintrc.json

Lines changed: 0 additions & 5 deletions
This file was deleted.

editors/vscode/fixtures/cross_module_extended_config/config/.oxlintrc.json

Lines changed: 0 additions & 8 deletions
This file was deleted.

editors/vscode/fixtures/cross_module_extended_config/dep-a.ts

Lines changed: 0 additions & 4 deletions
This file was deleted.

editors/vscode/fixtures/cross_module_extended_config/dep-b.ts

Lines changed: 0 additions & 4 deletions
This file was deleted.

editors/vscode/fixtures/cross_module_nested_config/dep-a.ts

Lines changed: 0 additions & 4 deletions
This file was deleted.

editors/vscode/fixtures/cross_module_nested_config/dep-b.ts

Lines changed: 0 additions & 4 deletions
This file was deleted.

editors/vscode/fixtures/cross_module_nested_config/folder/.oxlintrc.json

Lines changed: 0 additions & 8 deletions
This file was deleted.

editors/vscode/fixtures/cross_module_nested_config/folder/folder-dep-a.ts

Lines changed: 0 additions & 4 deletions
This file was deleted.

editors/vscode/fixtures/cross_module_nested_config/folder/folder-dep-b.ts

Lines changed: 0 additions & 4 deletions
This file was deleted.

editors/vscode/fixtures/nested_config/.oxlintrc.json

Lines changed: 0 additions & 5 deletions
This file was deleted.

editors/vscode/fixtures/nested_config/folder/.oxlintrc.json

Lines changed: 0 additions & 5 deletions
This file was deleted.

editors/vscode/fixtures/nested_config/folder/index.ts

Lines changed: 0 additions & 1 deletion
This file was deleted.

editors/vscode/fixtures/nested_config/index.ts

Lines changed: 0 additions & 1 deletion
This file was deleted.

editors/vscode/tests/e2e_server.spec.ts

Lines changed: 4 additions & 67 deletions
Original file line numberDiff line numberDiff line change
@@ -155,31 +155,18 @@ suite('E2E Diagnostics', () => {
155155
strictEqual(contentWithFixAll.toString(), 'if (foo === null) { bar();}');
156156
});
157157

158-
test('nested configs severity', async () => {
159-
await loadFixture('nested_config');
160-
const rootDiagnostics = await getDiagnostics('index.ts');
161-
const nestedDiagnostics = await getDiagnostics('folder/index.ts');
162-
163-
assert(typeof rootDiagnostics[0].code == 'object');
164-
strictEqual(rootDiagnostics[0].code.target.authority, 'oxc.rs');
165-
strictEqual(rootDiagnostics[0].severity, DiagnosticSeverity.Warning);
166-
167-
assert(typeof nestedDiagnostics[0].code == 'object');
168-
strictEqual(nestedDiagnostics[0].code.target.authority, 'oxc.rs');
169-
strictEqual(nestedDiagnostics[0].severity, DiagnosticSeverity.Error);
170-
});
171-
172158
testMultiFolderMode('different diagnostic severity', async () => {
173159
await loadFixture('debugger', WORKSPACE_DIR);
174-
await loadFixture('debugger_error', WORKSPACE_SECOND_DIR);
175-
176160
const firstDiagnostics = await getDiagnostics('debugger.js', WORKSPACE_DIR);
177-
const secondDiagnostics = await getDiagnostics('debugger.js', WORKSPACE_SECOND_DIR);
178161

179162
assert(typeof firstDiagnostics[0].code == 'object');
180163
strictEqual(firstDiagnostics[0].code.target.authority, 'oxc.rs');
181164
strictEqual(firstDiagnostics[0].severity, DiagnosticSeverity.Warning);
182165

166+
await loadFixture('debugger_error', WORKSPACE_SECOND_DIR);
167+
await sleep(500);
168+
const secondDiagnostics = await getDiagnostics('debugger.js', WORKSPACE_SECOND_DIR);
169+
183170
assert(typeof secondDiagnostics[0].code == 'object');
184171
strictEqual(secondDiagnostics[0].code.target.authority, 'oxc.rs');
185172
strictEqual(secondDiagnostics[0].severity, DiagnosticSeverity.Error);
@@ -218,54 +205,4 @@ suite('E2E Diagnostics', () => {
218205
strictEqual(secondDiagnostics[0].code.target.authority, 'oxc.rs');
219206
strictEqual(secondDiagnostics[0].severity, DiagnosticSeverity.Error);
220207
});
221-
222-
test('cross module', async () => {
223-
await loadFixture('cross_module');
224-
const diagnostics = await getDiagnostics('dep-a.ts');
225-
226-
strictEqual(diagnostics.length, 1);
227-
assert(typeof diagnostics[0].code == 'object');
228-
strictEqual(diagnostics[0].code.target.authority, 'oxc.rs');
229-
assert(
230-
diagnostics[0].message.startsWith("Dependency cycle detected"),
231-
);
232-
strictEqual(diagnostics[0].severity, DiagnosticSeverity.Error);
233-
strictEqual(diagnostics[0].range.start.line, 1);
234-
strictEqual(diagnostics[0].range.start.character, 18);
235-
strictEqual(diagnostics[0].range.end.line, 1);
236-
strictEqual(diagnostics[0].range.end.character, 30);
237-
});
238-
239-
test('cross module with nested config', async () => {
240-
await loadFixture('cross_module_nested_config');
241-
const diagnostics = await getDiagnostics('folder/folder-dep-a.ts');
242-
243-
strictEqual(diagnostics.length, 1);
244-
assert(typeof diagnostics[0].code == 'object');
245-
strictEqual(diagnostics[0].code.target.authority, 'oxc.rs');
246-
assert(
247-
diagnostics[0].message.startsWith("Dependency cycle detected"),
248-
);
249-
strictEqual(diagnostics[0].severity, DiagnosticSeverity.Error);
250-
strictEqual(diagnostics[0].range.start.line, 1);
251-
strictEqual(diagnostics[0].range.start.character, 18);
252-
strictEqual(diagnostics[0].range.end.line, 1);
253-
strictEqual(diagnostics[0].range.end.character, 37);
254-
});
255-
256-
test('cross module with extended config', async () => {
257-
await loadFixture('cross_module_extended_config');
258-
const diagnostics = await getDiagnostics('dep-a.ts');
259-
260-
assert(typeof diagnostics[0].code == 'object');
261-
strictEqual(diagnostics[0].code.target.authority, 'oxc.rs');
262-
assert(
263-
diagnostics[0].message.startsWith("Dependency cycle detected"),
264-
);
265-
strictEqual(diagnostics[0].severity, DiagnosticSeverity.Error);
266-
strictEqual(diagnostics[0].range.start.line, 1);
267-
strictEqual(diagnostics[0].range.start.character, 18);
268-
strictEqual(diagnostics[0].range.end.line, 1);
269-
strictEqual(diagnostics[0].range.end.character, 30);
270-
});
271208
});

editors/vscode/tests/test-helpers.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,6 @@ export async function loadFixture(fixture: string, workspaceDir: Uri = fixturesW
103103
export async function getDiagnostics(file: string, workspaceDir: Uri = fixturesWorkspaceUri()): Promise<Diagnostic[]> {
104104
const fileUri = Uri.joinPath(workspaceDir, 'fixtures', file);
105105
await window.showTextDocument(fileUri);
106-
await sleep(500);
107106
const diagnostics = languages.getDiagnostics(fileUri);
108107
await commands.executeCommand('workbench.action.closeActiveEditor');
109108
return diagnostics;

0 commit comments

Comments
 (0)