Skip to content

Commit 9432f45

Browse files
committed
test(editor): remove useless test + improve speed
1 parent d2f513d commit 9432f45

File tree

2 files changed

+4
-68
lines changed

2 files changed

+4
-68
lines changed

editors/vscode/tests/e2e_server.spec.ts

Lines changed: 4 additions & 67 deletions
Original file line numberDiff line numberDiff line change
@@ -141,31 +141,18 @@ suite('E2E Diagnostics', () => {
141141
strictEqual(contentWithFixAll.toString(), 'if (foo === null) { bar();}');
142142
});
143143

144-
test('nested configs severity', async () => {
145-
await loadFixture('nested_config');
146-
const rootDiagnostics = await getDiagnostics('index.ts');
147-
const nestedDiagnostics = await getDiagnostics('folder/index.ts');
148-
149-
assert(typeof rootDiagnostics[0].code == 'object');
150-
strictEqual(rootDiagnostics[0].code.target.authority, 'oxc.rs');
151-
strictEqual(rootDiagnostics[0].severity, DiagnosticSeverity.Warning);
152-
153-
assert(typeof nestedDiagnostics[0].code == 'object');
154-
strictEqual(nestedDiagnostics[0].code.target.authority, 'oxc.rs');
155-
strictEqual(nestedDiagnostics[0].severity, DiagnosticSeverity.Error);
156-
});
157-
158144
testMultiFolderMode('different diagnostic severity', async () => {
159145
await loadFixture('debugger', WORKSPACE_DIR);
160-
await loadFixture('debugger_error', WORKSPACE_SECOND_DIR);
161-
162146
const firstDiagnostics = await getDiagnostics('debugger.js', WORKSPACE_DIR);
163-
const secondDiagnostics = await getDiagnostics('debugger.js', WORKSPACE_SECOND_DIR);
164147

165148
assert(typeof firstDiagnostics[0].code == 'object');
166149
strictEqual(firstDiagnostics[0].code.target.authority, 'oxc.rs');
167150
strictEqual(firstDiagnostics[0].severity, DiagnosticSeverity.Warning);
168151

152+
await loadFixture('debugger_error', WORKSPACE_SECOND_DIR);
153+
await sleep(500);
154+
const secondDiagnostics = await getDiagnostics('debugger.js', WORKSPACE_SECOND_DIR);
155+
169156
assert(typeof secondDiagnostics[0].code == 'object');
170157
strictEqual(secondDiagnostics[0].code.target.authority, 'oxc.rs');
171158
strictEqual(secondDiagnostics[0].severity, DiagnosticSeverity.Error);
@@ -204,54 +191,4 @@ suite('E2E Diagnostics', () => {
204191
strictEqual(secondDiagnostics[0].code.target.authority, 'oxc.rs');
205192
strictEqual(secondDiagnostics[0].severity, DiagnosticSeverity.Error);
206193
});
207-
208-
test('cross module', async () => {
209-
await loadFixture('cross_module');
210-
const diagnostics = await getDiagnostics('dep-a.ts');
211-
212-
strictEqual(diagnostics.length, 1);
213-
assert(typeof diagnostics[0].code == 'object');
214-
strictEqual(diagnostics[0].code.target.authority, 'oxc.rs');
215-
assert(
216-
diagnostics[0].message.startsWith("Dependency cycle detected"),
217-
);
218-
strictEqual(diagnostics[0].severity, DiagnosticSeverity.Error);
219-
strictEqual(diagnostics[0].range.start.line, 1);
220-
strictEqual(diagnostics[0].range.start.character, 18);
221-
strictEqual(diagnostics[0].range.end.line, 1);
222-
strictEqual(diagnostics[0].range.end.character, 30);
223-
});
224-
225-
test('cross module with nested config', async () => {
226-
await loadFixture('cross_module_nested_config');
227-
const diagnostics = await getDiagnostics('folder/folder-dep-a.ts');
228-
229-
strictEqual(diagnostics.length, 1);
230-
assert(typeof diagnostics[0].code == 'object');
231-
strictEqual(diagnostics[0].code.target.authority, 'oxc.rs');
232-
assert(
233-
diagnostics[0].message.startsWith("Dependency cycle detected"),
234-
);
235-
strictEqual(diagnostics[0].severity, DiagnosticSeverity.Error);
236-
strictEqual(diagnostics[0].range.start.line, 1);
237-
strictEqual(diagnostics[0].range.start.character, 18);
238-
strictEqual(diagnostics[0].range.end.line, 1);
239-
strictEqual(diagnostics[0].range.end.character, 37);
240-
});
241-
242-
test('cross module with extended config', async () => {
243-
await loadFixture('cross_module_extended_config');
244-
const diagnostics = await getDiagnostics('dep-a.ts');
245-
246-
assert(typeof diagnostics[0].code == 'object');
247-
strictEqual(diagnostics[0].code.target.authority, 'oxc.rs');
248-
assert(
249-
diagnostics[0].message.startsWith("Dependency cycle detected"),
250-
);
251-
strictEqual(diagnostics[0].severity, DiagnosticSeverity.Error);
252-
strictEqual(diagnostics[0].range.start.line, 1);
253-
strictEqual(diagnostics[0].range.start.character, 18);
254-
strictEqual(diagnostics[0].range.end.line, 1);
255-
strictEqual(diagnostics[0].range.end.character, 30);
256-
});
257194
});

editors/vscode/tests/test-helpers.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,6 @@ export async function loadFixture(fixture: string, workspaceDir: Uri = fixturesW
103103
export async function getDiagnostics(file: string, workspaceDir: Uri = fixturesWorkspaceUri()): Promise<Diagnostic[]> {
104104
const fileUri = Uri.joinPath(workspaceDir, 'fixtures', file);
105105
await window.showTextDocument(fileUri);
106-
await sleep(500);
107106
const diagnostics = languages.getDiagnostics(fileUri);
108107
await commands.executeCommand('workbench.action.closeActiveEditor');
109108
return diagnostics;

0 commit comments

Comments
 (0)