Skip to content

CallsOnUnsupportedTypes failing #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tofutim opened this issue Nov 11, 2015 · 4 comments
Closed

CallsOnUnsupportedTypes failing #243

tofutim opened this issue Nov 11, 2015 · 4 comments

Comments

@tofutim
Copy link

tofutim commented Nov 11, 2015

Should this test be passing? It fails at Assert.That(types, Has.Member(typeof (DateTimeOffset))); but it seems that no types are ever added by the Serializer.
@tofutim
Copy link
Author

tofutim commented Nov 11, 2015

#196 suggest that this test can be ignored and that DateTimeOffset may already be supported. Looks like the test for Guid also fails.

@tofutim
Copy link
Author

tofutim commented Nov 11, 2015

DateTimeOffset is defined in Orm.cs as a bigint, so it is supported.

@tofutim
Copy link
Author

tofutim commented Nov 11, 2015

I fixed this in my PR by adding a DivideByZeroException as the not supported type. For the saving, I used Newtonsoft.Json to serialize but really it could be something else.

@tofutim tofutim mentioned this issue Nov 11, 2015
Closed
@oysteinkrog
Copy link
Owner

Awesome :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tofutim @oysteinkrog