From d26fe9c5fb8ae6fd4c9d8b06c595939c88a0717a Mon Sep 17 00:00:00 2001 From: Diamond Lewis Date: Mon, 2 Jun 2025 10:58:46 -0500 Subject: [PATCH 1/2] feat: Remove CoreManager `SERVER_AUTH_TYPE` and `SERVER_AUTH_TOKEN` infavor of `REQUEST_HEADERS` --- src/CoreManager.ts | 2 -- src/Parse.ts | 22 ---------------------- src/RESTController.ts | 4 ---- src/__tests__/Parse-test.js | 10 ---------- src/__tests__/RESTController-test.js | 10 ---------- 5 files changed, 48 deletions(-) diff --git a/src/CoreManager.ts b/src/CoreManager.ts index cdf1f1527..c894f0e1b 100644 --- a/src/CoreManager.ts +++ b/src/CoreManager.ts @@ -339,8 +339,6 @@ const config: Config & Record = { REQUEST_BATCH_SIZE: 20, REQUEST_HEADERS: {}, SERVER_URL: 'https://api.parse.com/1', - SERVER_AUTH_TYPE: null, - SERVER_AUTH_TOKEN: null, LIVEQUERY_SERVER_URL: null, ENCRYPTED_KEY: null, VERSION: 'js' + process.env.npm_package_version, diff --git a/src/Parse.ts b/src/Parse.ts index 71f3f834f..090eb2c82 100644 --- a/src/Parse.ts +++ b/src/Parse.ts @@ -226,28 +226,6 @@ const Parse = { return CoreManager.get('SERVER_URL'); }, - /** - * @property {string} Parse.serverAuthToken - * @static - */ - set serverAuthToken(value) { - CoreManager.set('SERVER_AUTH_TOKEN', value); - }, - get serverAuthToken() { - return CoreManager.get('SERVER_AUTH_TOKEN'); - }, - - /** - * @property {string} Parse.serverAuthType - * @static - */ - set serverAuthType(value) { - CoreManager.set('SERVER_AUTH_TYPE', value); - }, - get serverAuthType() { - return CoreManager.get('SERVER_AUTH_TYPE'); - }, - /** * @property {ParseLiveQuery} Parse.LiveQuery * @static diff --git a/src/RESTController.ts b/src/RESTController.ts index 251878e10..d9c225439 100644 --- a/src/RESTController.ts +++ b/src/RESTController.ts @@ -132,10 +132,6 @@ const RESTController = { if (isIdempotent) { headers['X-Parse-Request-Id'] = requestId; } - if (CoreManager.get('SERVER_AUTH_TYPE') && CoreManager.get('SERVER_AUTH_TOKEN')) { - headers['Authorization'] = - CoreManager.get('SERVER_AUTH_TYPE') + ' ' + CoreManager.get('SERVER_AUTH_TOKEN'); - } const customHeaders = CoreManager.get('REQUEST_HEADERS'); for (const key in customHeaders) { headers[key] = customHeaders[key]; diff --git a/src/__tests__/Parse-test.js b/src/__tests__/Parse-test.js index 2476e1cad..09e98917e 100644 --- a/src/__tests__/Parse-test.js +++ b/src/__tests__/Parse-test.js @@ -69,16 +69,6 @@ describe('Parse module', () => { expect(Parse.liveQueryServerURL).toBe('https://example.com'); }); - it('can set auth type and token', () => { - Parse.serverAuthType = 'bearer'; - expect(CoreManager.get('SERVER_AUTH_TYPE')).toBe('bearer'); - expect(Parse.serverAuthType).toBe('bearer'); - - Parse.serverAuthToken = 'some_token'; - expect(CoreManager.get('SERVER_AUTH_TOKEN')).toBe('some_token'); - expect(Parse.serverAuthToken).toBe('some_token'); - }); - it('can set idempotency', () => { expect(Parse.idempotency).toBe(false); Parse.idempotency = true; diff --git a/src/__tests__/RESTController-test.js b/src/__tests__/RESTController-test.js index 947467ee5..aa868689f 100644 --- a/src/__tests__/RESTController-test.js +++ b/src/__tests__/RESTController-test.js @@ -369,16 +369,6 @@ describe('RESTController', () => { }).toThrow('Cannot use the Master Key, it has not been provided.'); }); - it('sends auth header when the auth type and token flags are set', async () => { - CoreManager.set('SERVER_AUTH_TYPE', 'Bearer'); - CoreManager.set('SERVER_AUTH_TOKEN', 'some_random_token'); - mockFetch([{ status: 200, response: { results: [] } }]); - await RESTController.request('GET', 'classes/MyObject', {}, {}); - expect(fetch.mock.calls[0][1].headers['Authorization']).toEqual('Bearer some_random_token'); - CoreManager.set('SERVER_AUTH_TYPE', null); - CoreManager.set('SERVER_AUTH_TOKEN', null); - }); - it('reports upload/download progress of the AJAX request when callback is provided', async () => { mockFetch([{ status: 200, response: { success: true } }], { 'Content-Length': 10 }); const options = { From 021a54b3c25e5a7c91ea2f5c5cb5808bbcdfdc4c Mon Sep 17 00:00:00 2001 From: Diamond Lewis Date: Mon, 2 Jun 2025 12:52:07 -0500 Subject: [PATCH 2/2] Update Parse.d.ts --- types/Parse.d.ts | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/types/Parse.d.ts b/types/Parse.d.ts index b53d19e7e..3baee384e 100644 --- a/types/Parse.d.ts +++ b/types/Parse.d.ts @@ -282,16 +282,6 @@ declare const Parse: { * @static */ serverURL: any; - /** - * @property {string} Parse.serverAuthToken - * @static - */ - serverAuthToken: any; - /** - * @property {string} Parse.serverAuthType - * @static - */ - serverAuthType: any; /** * @property {ParseLiveQuery} Parse.LiveQuery * @static