Hdl 285 paypal sdk header: Fixing Case Sensitivity (#9)

* Config Encoder and Client to enforce lowercase Content Types and Unit tests

* Updated version, changelog, and license

Co-authored-by: Hakim <[email protected]>

Author: HDLahlou

CHANGELOG.md

@@ -1,2 +1,5 @@
+## 1.0.1
+* Fix Case Sensitivity of Content Type for deserialization process
+
 ## 1.0.0
 * First Release

LICENSE

@@ -1,4 +1,4 @@
-Copyright (c) 2009-2019 PayPal, Inc.
+Copyright (c) 2009-2021 PayPal, Inc.
 
 Permission is hereby granted, free of charge, to any person
 obtaining a copy of this software and associated documentation

lib/paypalhttp/encoder.js

@@ -37,6 +37,8 @@ class Encoder {
     if (!contentType) {
       throw new Error('HttpRequest does not have Content-Type header set');
     }
+    // Forcing Lowercase to ensure deserializing happens properly
+    contentType = contentType.toLowerCase();
 
     let encoder = this._encoder(contentType);
 

lib/paypalhttp/http_client.js

@@ -53,7 +53,11 @@ class HttpClient {
 
     Object.keys(headers).forEach(function (key) {
       if (key != null) {
-        formattedHeader[key.toLowerCase()] = headers[key];
+        if (key.toLowerCase() === 'content-type')	{
+          formattedHeader[key.toLowerCase()] = headers[key].toLowerCase();
+        } else {
+          formattedHeader[key.toLowerCase()] = headers[key];
+        }
       }
     });
     return formattedHeader;

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@paypal/paypalhttp",
-  "version": "1.0.0",
+  "version": "1.0.1",
   "description": "A library for integrating with PayPalHttp.",
   "keywords": [
     "paypalhttp",

spec/unit/encoder_spec.js

@@ -144,6 +144,17 @@ describe('encoder', function () {
       assert.deepEqual(deserialized.three, ['one', 'two', 'three']);
     });
 
+    it('deserializes a case insensitive response with content-type == application/JSON', function () {
+      let headers = {
+        'content-type': 'application/JSON; charset=utf8'
+      };
+      let body = '{"one":"two","three":["one","two","three"]}';
+      let deserialized = encoder.deserializeResponse(body, headers);
+
+      assert.equal(deserialized.one, 'two');
+      assert.deepEqual(deserialized.three, ['one', 'two', 'three']);
+    });
+
     it('deserializes a response with content-type == text/*', function () {
       let headers = {
         'content-type': 'text/asdf; charset=utf8'
@@ -153,6 +164,15 @@ describe('encoder', function () {
       assert.equal(encoder.deserializeResponse(body, headers), body);
     });
 
+    it('deserializes a case insensitive response with content-type == TEXT/*', function () {
+      let headers = {
+        'content-type': 'TEXT/asdf; charset=utf8'
+      };
+      let body = 'some asdf text';
+
+      assert.equal(encoder.deserializeResponse(body, headers), body);
+    });
+
     it('throws when response content-type == multipart/*', function () {
       let headers = {
         'content-type': 'multipart/form-data; charset=utf8'

spec/unit/http_client_spec.js

@@ -29,6 +29,24 @@ describe('HttpClient', function () {
     });
   });
 
+  describe('formatHeaders', function () {
+    it('returns formatted headers', function () {
+      let headers = {
+        'Content-Type': 'application/JSON',
+        key: 'value'
+      };
+
+      let expected = {
+        'content-type': 'application/json',
+        key: 'value'
+      };
+
+      let formattedHeaders = this.http.formatHeaders(headers);
+
+      assert.equal(formattedHeaders['content-type'], expected['content-type']);
+    });
+  });
+
   describe('addInjector', function () {
     it('adds to the injectors array', function () {
       function injector(request) {}