Add check for job class existance (#24)

Author: montekidlo

src/Job/QlessJob.php

@@ -6,6 +6,7 @@
 use Illuminate\Container\Container;
 use Illuminate\Queue\Jobs\Job;
 use Illuminate\Contracts\Queue\Job as JobContract;
+use Illuminate\Queue\Jobs\JobName;
 use Illuminate\Queue\ManuallyFailedException;
 use LaravelQless\Queue\QlessQueue;
 use Qless\Jobs\BaseJob;
@@ -194,4 +195,21 @@ public function getRawBody()
     {
         return $this->payload;
     }
+    
+    /**
+     * Process an exception that caused the job to fail.
+     *
+     * @param  \Throwable|null  $e
+     * @return void
+     */
+    protected function failed($e)
+    {
+        $payload = $this->payload();
+
+        [$class, $method] = JobName::parse($payload['job']);
+
+        if (class_exists($class) && method_exists($this->instance = $this->resolve($class), 'failed')) {
+            $this->instance->failed($payload['data'], $e);
+        }
+    }
 }

tests/Job/QlessJobTest.php

@@ -3,9 +3,11 @@
 namespace LaravelQless\Tests\Job;
 
 use Illuminate\Container\Container;
+use Illuminate\Contracts\Container\BindingResolutionException;
 use LaravelQless\Contracts\JobHandler;
 use LaravelQless\Queue\QlessQueue;
 use LaravelQless\Tests\Helpers\ModifierTrait;
+use LaravelQless\Tests\Stub\JobStub;
 use Orchestra\Testbench\TestCase;
 use LaravelQless\Job\QlessJob;
 use Qless\Jobs\BaseJob;
@@ -53,6 +55,48 @@ public function testFireFailed(): void
     {
         self::markTestSkipped('Refactor class to set `failed` property');
     }
+    public function testFireFailedWithNotExistentClass(): void
+    {
+        $jobMock = $this->getJob();
+        $jobMock->method('getData')
+            ->willReturn(new JobData(['key' => 'value']));
+
+        $jobMock->method('__get')
+            ->with('failed')
+            ->willReturn(true);
+
+        $container = $this->getContainer();
+        $container->method('make')
+            ->willThrowException(new BindingResolutionException());
+
+        $payload = json_encode(['job' => 'Foo@fire']);
+
+        $job = (new QlessJob($container, $this->getQueue(), $this->getJobHandler(), $jobMock, $payload));
+        $job->fire();
+
+        self::assertNull($job->getResolvedJob());
+    }
+
+    public function testFireFailedWithExistentClass(): void
+    {
+        $jobMock = $this->getJob();
+        $jobMock->method('getData')
+            ->willReturn(new JobData(['key' => 'value']));
+
+        $jobMock->method('__get')
+            ->with('failed')
+            ->willReturn(true);
+
+        $container = $this->getContainer();
+        $container->method('make')->with(JobStub::class)->willReturn(new JobStub());
+
+        $payload = json_encode(['job' => JobStub::class . '@failed', 'data' => []]);
+
+        $job = (new QlessJob($container, $this->getQueue(), $this->getJobHandler(), $jobMock, $payload));
+        $job->fire();
+
+        self::assertNotNull($job->getResolvedJob());
+    }
 
     public function testRelease(): void
     {

tests/Stub/JobStub.php

@@ -0,0 +1,18 @@
+<?php
+namespace LaravelQless\Tests\Stub;
+
+/**
+ * Class JobStub
+ * 
+ * @package LaravelQless\Tests\Stub
+ */
+class JobStub
+{
+    public function fire()
+    {
+    }
+    
+    public function failed()
+    {
+    }
+}