Update gems + adapt to latest rubocop styles

pdobb · pdobb · commit 33408b6d29f9 · 2025-03-23T12:04:35.000-05:00
gemwork v0.7.14 brings in new rubocop styles / adjustments, that we
must catch up with here.
diff --git a/.rubocop.yml b/.rubocop.yml
@@ -1,5 +1,5 @@
 # Load Rubocop plugins.
-require:
+plugins:
   - rubocop-rake
   - rubocop-minitest
   - rubocop-performance
diff --git a/Gemfile.lock b/Gemfile.lock
@@ -7,18 +7,18 @@ GEM
   remote: https://rubygems.org/
   specs:
     ansi (1.5.0)
-    ast (2.4.2)
+    ast (2.4.3)
     benchmark-ips (2.14.0)
     bigdecimal (3.1.9)
     builder (3.3.0)
-    concurrent-ruby (1.3.4)
+    concurrent-ruby (1.3.5)
     date (3.4.1)
     debug (1.10.0)
       irb (~> 1.10)
       reline (>= 0.3.8)
     docile (1.4.1)
-    dry-configurable (1.2.0)
-      dry-core (~> 1.0, < 2)
+    dry-configurable (1.3.0)
+      dry-core (~> 1.1)
       zeitwerk (~> 2.6)
     dry-core (1.1.0)
       concurrent-ruby (~> 1.0)
@@ -39,14 +39,14 @@ GEM
       dry-logic (>= 1.4, < 2)
       dry-types (>= 1.7, < 2)
       zeitwerk (~> 2.6)
-    dry-types (1.7.2)
+    dry-types (1.8.2)
       bigdecimal (~> 3.0)
       concurrent-ruby (~> 1.0)
       dry-core (~> 1.0)
       dry-inflector (~> 1.0)
       dry-logic (~> 1.4)
       zeitwerk (~> 2.6)
-    gemwork (0.7.4)
+    gemwork (0.7.14)
       debug
       irb
       minitest
@@ -60,13 +60,15 @@ GEM
       simplecov
       yard
     io-console (0.8.0)
-    irb (1.14.3)
+    irb (1.15.1)
+      pp (>= 0.6.0)
       rdoc (>= 4.0.0)
       reline (>= 0.4.2)
-    json (2.9.1)
-    language_server-protocol (3.17.0.3)
-    logger (1.6.4)
-    minitest (5.25.4)
+    json (2.10.2)
+    language_server-protocol (3.17.0.4)
+    lint_roller (1.1.0)
+    logger (1.6.6)
+    minitest (5.25.5)
     minitest-reporters (1.7.1)
       ansi
       builder
@@ -75,59 +77,67 @@ GEM
     much-stub (0.1.10)
     object_identifier (0.10.0)
     parallel (1.26.3)
-    parser (3.3.6.0)
+    parser (3.3.7.2)
       ast (~> 2.4.1)
       racc
-    psych (5.2.2)
+    pp (0.6.2)
+      prettyprint
+    prettyprint (0.2.0)
+    psych (5.2.3)
       date
       stringio
     racc (1.8.1)
     rainbow (3.1.1)
     rake (13.2.1)
-    rdoc (6.10.0)
+    rdoc (6.12.0)
       psych (>= 4.0.0)
-    reek (6.3.0)
+    reek (6.4.0)
       dry-schema (~> 1.13.0)
+      logger (~> 1.6)
       parser (~> 3.3.0)
       rainbow (>= 2.0, < 4.0)
       rexml (~> 3.1)
     regexp_parser (2.10.0)
     reline (0.6.0)
       io-console (~> 0.5)
-    rexml (3.4.0)
-    rubocop (1.69.2)
+    rexml (3.4.1)
+    rubocop (1.74.0)
       json (~> 2.3)
-      language_server-protocol (>= 3.17.0)
+      language_server-protocol (~> 3.17.0.2)
+      lint_roller (~> 1.1.0)
       parallel (~> 1.10)
       parser (>= 3.3.0.2)
       rainbow (>= 2.2.2, < 4.0)
       regexp_parser (>= 2.9.3, < 3.0)
-      rubocop-ast (>= 1.36.2, < 2.0)
+      rubocop-ast (>= 1.38.0, < 2.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 2.4.0, < 4.0)
-    rubocop-ast (1.37.0)
-      parser (>= 3.3.1.0)
-    rubocop-minitest (0.36.0)
-      rubocop (>= 1.61, < 2.0)
-      rubocop-ast (>= 1.31.1, < 2.0)
-    rubocop-performance (1.23.1)
-      rubocop (>= 1.48.1, < 2.0)
-      rubocop-ast (>= 1.31.1, < 2.0)
-    rubocop-rake (0.6.0)
-      rubocop (~> 1.0)
+    rubocop-ast (1.41.0)
+      parser (>= 3.3.7.2)
+    rubocop-minitest (0.37.1)
+      lint_roller (~> 1.1)
+      rubocop (>= 1.72.1, < 2.0)
+      rubocop-ast (>= 1.38.0, < 2.0)
+    rubocop-performance (1.24.0)
+      lint_roller (~> 1.1)
+      rubocop (>= 1.72.1, < 2.0)
+      rubocop-ast (>= 1.38.0, < 2.0)
+    rubocop-rake (0.7.1)
+      lint_roller (~> 1.1)
+      rubocop (>= 1.72.1)
     ruby-progressbar (1.13.0)
     simplecov (0.22.0)
       docile (~> 1.1)
       simplecov-html (~> 0.11)
       simplecov_json_formatter (~> 0.1)
     simplecov-html (0.13.1)
     simplecov_json_formatter (0.1.4)
-    stringio (3.1.2)
-    unicode-display_width (3.1.3)
+    stringio (3.1.5)
+    unicode-display_width (3.1.4)
       unicode-emoji (~> 4.0, >= 4.0.4)
     unicode-emoji (4.0.4)
     yard (0.9.37)
-    zeitwerk (2.7.1)
+    zeitwerk (2.7.2)
 
 PLATFORMS
   arm64-darwin-23
@@ -142,4 +152,4 @@ DEPENDENCIES
   rake
 
 BUNDLED WITH
-   2.6.2
+   2.6.6
diff --git a/lib/object_inspector.rb b/lib/object_inspector.rb
@@ -51,7 +51,7 @@ def initialize
 
     def formatter_class=(value)
       unless value.is_a?(Class)
-        raise TypeError, "Formatter must be a Class constant"
+        raise(TypeError, "Formatter must be a Class constant")
       end
 
       @formatter_class = value
diff --git a/lib/object_inspector/formatters/base_formatter.rb b/lib/object_inspector/formatters/base_formatter.rb
@@ -16,7 +16,7 @@ def initialize(inspector)
   #
   # @return [String]
   def call
-    raise NotImplementedError
+    raise(NotImplementedError)
   end
 
   # Delegates to {Inspector#wrapped_object_inspection_result}.
diff --git a/rakelib/bump.rake b/rakelib/bump.rake
@@ -48,7 +48,7 @@ def replace_in_file(path, replacements)
   original_file_contents = file_contents.dup
 
   replacements.each do |regex, text|
-    raise "Can't find #{regex} in #{path}" unless regex.match?(file_contents)
+    raise("Can't find #{regex} in #{path}") unless regex.match?(file_contents)
 
     file_contents.gsub!(regex) do |match|
       match[regex, 1] = text
diff --git a/rakelib/gemwork.rake b/rakelib/gemwork.rake
@@ -4,8 +4,8 @@ spec = Gem::Specification.find_by_name("gemwork")
 
 # Load additional tasks defined by Gemwork.
 Dir.glob(
-  Pathname.new(spec.gem_dir).
-    join("lib", "tasks", "{util,rubocop,reek,test,prettier}.rake")) do |task|
+  Pathname.new(spec.gem_dir)
+    .join("lib/tasks", "{util,test,rubocop,reek,prettier}.rake")) do |task|
   load(task)
 end
 
diff --git a/test/object_inspector/inspector_test.rb b/test/object_inspector/inspector_test.rb
@@ -175,8 +175,8 @@ class ObjectInspector::InspectorTest < Minitest::Spec
         subject { klazz.new(wrapper_for_full_test_object1) }
 
         it "returns Object#to_model#inspect" do
-          _(subject.wrapped_object_inspection_result).
-            must_equal("<Identification[id:1](FLAG1) Info: 1 :: Name: 1>")
+          _(subject.wrapped_object_inspection_result)
+            .must_equal("<Identification[id:1](FLAG1) Info: 1 :: Name: 1>")
         end
       end
 
@@ -195,21 +195,21 @@ class ObjectInspector::InspectorTest < Minitest::Spec
       context "GIVEN #value is a Symbol" do
         it "returns Object#<value>, GIVEN Object responds to #value" do
           _(
-            subject.__send__(:evaluate_passed_in_value, :simple_test_method)).
-            must_equal("TEST_RESULT")
+            subject.__send__(:evaluate_passed_in_value, :simple_test_method))
+            .must_equal("TEST_RESULT")
         end
 
         it "returns #value, GIVEN Object does not respond to #value" do
-          _(subject.__send__(:evaluate_passed_in_value, :unknown_method1)).
-            must_equal(:unknown_method1)
+          _(subject.__send__(:evaluate_passed_in_value, :unknown_method1))
+            .must_equal(:unknown_method1)
         end
       end
 
       context "GIVEN #value is not a Symbol" do
         it "returns #value" do
           _(
-            subject.__send__(:evaluate_passed_in_value, "simple_test_method")).
-            must_equal("simple_test_method")
+            subject.__send__(:evaluate_passed_in_value, "simple_test_method"))
+            .must_equal("simple_test_method")
         end
       end
     end
diff --git a/test/object_inspector/scope_test.rb b/test/object_inspector/scope_test.rb
@@ -76,7 +76,7 @@ class SimpleTestObject # rubocop:disable Lint/EmptyClass
       subject { self_scope }
 
       it "raises NoMethodError" do
-        _(-> { subject.unknown_method }).must_raise NoMethodError
+        _(-> { subject.unknown_method }).must_raise(NoMethodError)
       end
     end
 
@@ -177,8 +177,8 @@ class SimpleTestObject # rubocop:disable Lint/EmptyClass
       end
 
       it "returns nil, GIVEN an array of `nil`s with nested arrays of `nil`s" do
-        _(subject.join_name([nil, nil, [nil, nil, [nil, nil]]])).
-          must_be_nil
+        _(subject.join_name([nil, nil, [nil, nil, [nil, nil]]]))
+          .must_be_nil
       end
     end
 
@@ -206,8 +206,8 @@ class SimpleTestObject # rubocop:disable Lint/EmptyClass
       end
 
       it "returns nil, GIVEN an array of `nil`s with nested arrays of `nil`s" do
-        _(subject.join_flags([nil, nil, [nil, nil, [nil, nil]]])).
-          must_be_nil
+        _(subject.join_flags([nil, nil, [nil, nil, [nil, nil]]]))
+          .must_be_nil
       end
     end
 
@@ -235,8 +235,8 @@ class SimpleTestObject # rubocop:disable Lint/EmptyClass
       end
 
       it "returns nil, GIVEN an array of `nil`s with nested arrays of `nil`s" do
-        _(subject.join_issues([nil, nil, [nil, nil, [nil, nil]]])).
-          must_be_nil
+        _(subject.join_issues([nil, nil, [nil, nil, [nil, nil]]]))
+          .must_be_nil
       end
     end
 
@@ -264,8 +264,8 @@ class SimpleTestObject # rubocop:disable Lint/EmptyClass
       end
 
       it "returns nil, GIVEN an array of `nil`s with nested arrays of `nil`s" do
-        _(subject.join_info([nil, nil, [nil, nil, [nil, nil]]])).
-          must_be_nil
+        _(subject.join_info([nil, nil, [nil, nil, [nil, nil]]]))
+          .must_be_nil
       end
     end
   end
diff --git a/test/test_helper.rb b/test/test_helper.rb
@@ -2,7 +2,7 @@
 
 require "gemwork/test/support/simplecov"
 
-$LOAD_PATH.unshift File.expand_path("../lib", __dir__)
+$LOAD_PATH.unshift(File.expand_path("../lib", __dir__))
 require "object_inspector"
 
 require "minitest/autorun"

Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,7 @@ def initialize(inspector)`
`16`	`16`	`#`
`17`	`17`	`# @return [String]`
`18`	`18`	`def call`
`19`		`- raise NotImplementedError`
	`19`	`+ raise(NotImplementedError)`
`20`	`20`	`end`
`21`	`21`
`22`	`22`	`# Delegates to {Inspector#wrapped_object_inspection_result}.`