Remove use of OpenStruct + Fix up test suite

We no longer use OpenStruct as it is slow and the library (ostrcut) is
being removed from Ruby core in v3.5

Also, add `issues` to the CombiningFormatter. This doesn't really effect
anything/anyone since this formatter was not being used and, being
slower, there's no reason to believe anyone was opting into using it
over the TemplatingFormatter. But... it was a incongruity in the test
suite so I wanted to clean it up.

Also, fix up the test suite:
- Remove use of OpenStruct, which was plentiful
- Refactor `klazz` -> `unit_class`, as has been my new standard for a
  while now
- Add missing tests for inclusion of `issues` in output Strings

Author: pdobb

.rubocop.yml

@@ -9,6 +9,3 @@ inherit_gem:
 
 AllCops:
   TargetRubyVersion: 3.2
-
-Performance/OpenStruct:
-  Enabled: false # Reconsider later.

CHANGELOG.md

@@ -1,5 +1,6 @@
 ## [Unreleased]
 
+- Add `issues` to the (probably never-used) CombiningFormatter + Internal refactoring/cleanup.
 - Update benchmark code + results info for Ruby v3.4 in README
 
 ### 0.8.2 - 2025-1-4

bin/console

@@ -4,7 +4,6 @@
 require "bundler/setup"
 require "object_inspector"
 require "object_identifier"
-require "ostruct"
 
 # You can add fixtures and/or initialization code here to make experimenting
 # with your gem easier. You can also use a different console, if you like.

lib/object_inspector/formatters/combining_formatter.rb

@@ -38,6 +38,7 @@ def strings
     [
       build_identification_string,
       build_flags_string,
+      build_issues_string,
       build_info_string,
       build_name_string,
     ].compact
@@ -51,6 +52,10 @@ def build_flags_string
     "(#{flags.to_s.upcase})" if flags
   end
 
+  def build_issues_string
+    " !!#{issues.to_s.upcase}!!" if issues
+  end
+
   def build_info_string
     " #{info}" if info
   end

test/object_inspector/conversions_test.rb

@@ -4,22 +4,22 @@
 
 class ObjectInspector::ConversionsTest < Minitest::Spec
   describe "ObjectInspector::Conversions" do
-    let(:klazz) { ObjectInspector::Conversions }
+    let(:unit_class) { ObjectInspector::Conversions }
 
     let(:scope1) { ObjectInspector::Scope.new }
 
     describe ".Scope" do
-      subject { klazz }
+      subject { unit_class }
 
       context "GIVEN an ObjectInspector::Scope" do
         it "returns the same ObjectInspector::Scope" do
-          _(klazz.Scope(scope1).object_id).must_equal(scope1.object_id)
+          _(unit_class.Scope(scope1).object_id).must_equal(scope1.object_id)
         end
       end
 
       context "GIVEN a Symbol" do
         it "returns a new Scope for the given Symbol" do
-          new_scope = klazz.Scope(:verbose)
+          new_scope = unit_class.Scope(:verbose)
           _(new_scope.names).must_include("verbose")
         end
       end

test/object_inspector/formatters/base_formatter_test.rb

@@ -4,11 +4,11 @@
 
 class ObjectInspector::BaseFormatterTest < Minitest::Spec
   describe "ObjectInspector::BaseFormatter" do
-    let(:klazz) { ObjectInspector::BaseFormatter }
+    let(:unit_class) { ObjectInspector::BaseFormatter }
 
     describe "#call" do
       it "raises NotImplementedError" do
-        _(-> { klazz.new(Object.new).call }).must_raise(
+        _(-> { unit_class.new(Object.new).call }).must_raise(
           NotImplementedError)
       end
     end

test/object_inspector/formatters/combining_formatter_test.rb

@@ -7,58 +7,87 @@ class SimpleTestObject
     def inspect_identification; "SIMPLE_TEST_OBJECT" end
   end
 
+  InspectableTestClass =
+    Struct.new(
+      :identification,
+      :flags,
+      :issues,
+      :info,
+      :name,
+      :wrapped_object_inspection_result,
+      keyword_init: true) do
+      # :reek:LongParameterList
+      def initialize(
+            identification: nil,
+            flags: nil,
+            issues: nil,
+            info: nil,
+            name: nil,
+            wrapped_object_inspection_result: nil)
+        super
+      end
+    end
+
   describe "ObjectInspector::CombiningFormatter" do
     let(:klazz) { ObjectInspector::CombiningFormatter }
     let(:inspector_klazz) { ObjectInspector::Inspector }
 
     let(:inspector_with_wrapped_object) {
-      OpenStruct.new(
+      InspectableTestClass.new(
         identification: "WRAPPER",
         wrapped_object_inspection_result:
           inspector_klazz.new(SimpleTestObject.new))
     }
+    let(:inspector_with_flags_and_issues_and_info_and_name) {
+      InspectableTestClass.new(
+        identification: "IDENTIFICATION",
+        flags: "FLAG1 | FLAG2",
+        issues: "ISSUE1 | ISSUE2",
+        info: "INFO",
+        name: "NAME")
+    }
     let(:inspector_with_flags_and_info_and_name) {
-      OpenStruct.new(
+      InspectableTestClass.new(
         identification: "IDENTIFICATION",
         flags: "FLAG1 | FLAG2",
         info: "INFO",
         name: "NAME")
     }
     let(:inspector_with_flags_and_info) {
-      OpenStruct.new(
+      InspectableTestClass.new(
         identification: "IDENTIFICATION",
         flags: "FLAG1 | FLAG2",
         info: "INFO")
     }
     let(:inspector_with_flags_and_name) {
-      OpenStruct.new(
+      InspectableTestClass.new(
         identification: "IDENTIFICATION",
         flags: "FLAG1 | FLAG2",
         name: "NAME")
     }
     let(:inspector_with_info_and_name) {
-      OpenStruct.new(
+      InspectableTestClass.new(
         identification: "IDENTIFICATION",
         info: "INFO",
         name: "NAME")
     }
     let(:inspector_with_name) {
-      OpenStruct.new(
+      InspectableTestClass.new(
         identification: "IDENTIFICATION",
         name: "NAME")
     }
     let(:inspector_with_flags) {
-      OpenStruct.new(
+      InspectableTestClass.new(
         identification: "IDENTIFICATION",
         flags: "FLAG1 | FLAG2")
     }
     let(:inspector_with_info) {
-      OpenStruct.new(
+      InspectableTestClass.new(
         identification: "IDENTIFICATION",
         info: "INFO")
     }
     let(:inspector_with_base) {
-      OpenStruct.new(
+      InspectableTestClass.new(
         identification: "IDENTIFICATION")
     }
 
@@ -83,6 +112,15 @@ def inspect_identification; "SIMPLE_TEST_OBJECT" end
         end
       end
 
+      context "GIVEN an Inspector with #flags #issues and #info and #name" do
+        subject { klazz.new(inspector_with_flags_and_issues_and_info_and_name) }
+
+        it "returns the expected String" do
+          _(subject.call).must_equal(
+            "<IDENTIFICATION(FLAG1 | FLAG2) !!ISSUE1 | ISSUE2!! INFO :: NAME>")
+        end
+      end
+
       context "GIVEN an Inspector with #flags and #info" do
         subject { klazz.new(inspector_with_flags_and_info) }