Skip to content

[Refactoring-UI] Error when pushing up method if same one exists in superclass #18214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JanBliznicenko opened this issue May 27, 2025 · 2 comments

Comments

@JanBliznicenko
Copy link
Contributor

JanBliznicenko commented May 27, 2025

When we try to push up a method while a method with same selector exists in the superclass, the refactoring ends up in an error.

Steps to reproduce:

  1. Create a method named 'abc' in any class that has a subclass
  2. Create a method named 'abc' in its direct subclass
  3. Right click the 'abc' method in the subclass
  4. Refactorings
  5. (R) Pull up
  6. Refactor

=> Instance of RBNegationCondition class did not understand #strategyChoiceClass, in RePullUpMethodDriver

Issue is present in the released Pharo 13 and current build of Pharo 14.

@Ducasse
Copy link
Member

Ducasse commented Jun 2, 2025

Thanks for the report

@github-project-automation github-project-automation bot moved this to For Later (kind of Backlog) in Refactoring Engine Jun 2, 2025
@Ducasse
Copy link
Member

Ducasse commented Jun 3, 2025

I can reproduce it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: For Later (kind of Backlog)
Development

No branches or pull requests

2 participants