AttributeNamedArgumentsRule made fixable

Author: ondrejmirtes

build/PHPStan/Build/AttributeNamedArgumentsRule.php

@@ -5,8 +5,11 @@
 use PhpParser\Node;
 use PhpParser\Node\Attribute;
 use PHPStan\Analyser\Scope;
+use PHPStan\Reflection\ReflectionProvider;
 use PHPStan\Rules\Rule;
 use PHPStan\Rules\RuleErrorBuilder;
+use PHPStan\ShouldNotHappenException;
+use function count;
 use function sprintf;
 
 /**
@@ -15,22 +18,60 @@
 final class AttributeNamedArgumentsRule implements Rule
 {
 
+	public function __construct(private ReflectionProvider $reflectionProvider)
+	{
+	}
+
 	public function getNodeType(): string
 	{
 		return Attribute::class;
 	}
 
 	public function processNode(Node $node, Scope $scope): array
 	{
+		$attributeName = $node->name->toString();
+		if (!$this->reflectionProvider->hasClass($attributeName)) {
+			return [];
+		}
+
+		$attributeReflection = $this->reflectionProvider->getClass($attributeName);
+		if (!$attributeReflection->hasConstructor()) {
+			return [];
+		}
+		$constructor = $attributeReflection->getConstructor();
+		$variants = $constructor->getVariants();
+		if (count($variants) !== 1) {
+			return [];
+		}
+
+		$parameters = $variants[0]->getParameters();
+
 		foreach ($node->args as $arg) {
 			if ($arg->name !== null) {
-				continue;
+				break;
 			}
 
 			return [
 				RuleErrorBuilder::message(sprintf('Attribute %s is not using named arguments.', $node->name->toString()))
 					->identifier('phpstan.attributeWithoutNamedArguments')
 					->nonIgnorable()
+					->fixNode($node, static function (Node $node) use ($parameters) {
+						$args = $node->args;
+						foreach ($args as $i => $arg) {
+							if ($arg->name !== null) {
+								break;
+							}
+
+							$parameterName = $parameters[$i]->getName();
+							if ($parameterName === '') {
+								throw new ShouldNotHappenException();
+							}
+
+							$arg->name = new Node\Identifier($parameterName);
+						}
+
+						return $node;
+					})
 					->build(),
 			];
 		}

tests/PHPStan/Build/AttributeNamedArgumentsRuleTest.php

@@ -0,0 +1,34 @@
+<?php declare(strict_types = 1);
+
+namespace PHPStan\Build;
+
+use PHPStan\Rules\Rule;
+use PHPStan\Testing\RuleTestCase;
+
+/**
+ * @extends RuleTestCase<AttributeNamedArgumentsRule>
+ */
+class AttributeNamedArgumentsRuleTest extends RuleTestCase
+{
+
+	protected function getRule(): Rule
+	{
+		return new AttributeNamedArgumentsRule($this->createReflectionProvider());
+	}
+
+	public function testRule(): void
+	{
+		$this->analyse([__DIR__ . '/data/attribute-arguments.php'], [
+			[
+				'Attribute PHPStan\DependencyInjection\AutowiredService is not using named arguments.',
+				13,
+			],
+		]);
+	}
+
+	public function testFix(): void
+	{
+		$this->fix(__DIR__ . '/data/attribute-arguments.php', __DIR__ . '/data/attribute-arguments.php.fixed');
+	}
+
+}

tests/PHPStan/Build/data/attribute-arguments.php

@@ -0,0 +1,17 @@
+<?php
+
+namespace AttributeArguments;
+
+use PHPStan\DependencyInjection\AutowiredService;
+
+#[AutowiredService(name: 'foo')]
+class Foo
+{
+
+}
+
+#[AutowiredService('foo')]
+class Bar
+{
+
+}

tests/PHPStan/Build/data/attribute-arguments.php.fixed

@@ -0,0 +1,17 @@
+<?php
+
+namespace AttributeArguments;
+
+use PHPStan\DependencyInjection\AutowiredService;
+
+#[AutowiredService(name: 'foo')]
+class Foo
+{
+
+}
+
+#[AutowiredService(name: 'foo')]
+class Bar
+{
+
+}