Skip to content

React 19 #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
paulocoutinhox opened this issue Mar 17, 2025 · 3 comments · May be fixed by #133
Open

React 19 #132

paulocoutinhox opened this issue Mar 17, 2025 · 3 comments · May be fixed by #133

Comments

@paulocoutinhox
Copy link

paulocoutinhox commented Mar 17, 2025

Hi,

Can you please update to React 19?

Error:

chunk-KNK3UTB7.js?v=ae6950dd:5305 Uncaught TypeError: import_react_dom6.default.render is not a function
    at render (ecctrl.js?v=ae6950dd:5923:29)
    at ecctrl.js?v=ae6950dd:11460:11
    at react-stack-bottom-frame (chunk-HQOX6EPQ.js?v=ae6950dd:10257:20)
    at runWithFiberInDEV (chunk-HQOX6EPQ.js?v=ae6950dd:638:18)
    at commitHookEffectListMount (chunk-HQOX6EPQ.js?v=ae6950dd:6678:123)
    at commitHookPassiveMountEffects (chunk-HQOX6EPQ.js?v=ae6950dd:6736:60)
    at reconnectPassiveEffects (chunk-HQOX6EPQ.js?v=ae6950dd:8137:13)
    at recursivelyTraverseReconnectPassiveEffects (chunk-HQOX6EPQ.js?v=ae6950dd:8116:11)
    at reconnectPassiveEffects (chunk-HQOX6EPQ.js?v=ae6950dd:8175:13)
    at recursivelyTraverseReconnectPassiveEffects (chunk-HQOX6EPQ.js?v=ae6950dd:8116:11)
The error message import_react_dom6.default.render is not a function indicates that the ecctrl library is trying to use the legacy ReactDOM.render() method, which has been removed in React 18 and above. In React 18+, the recommended way to render is using createRoot.

The R3F already is using version 19:
https://github.com/pmndrs/react-three-fiber/blob/master/package.json

Thanks.

@Envoy-VC
Copy link

Envoy-VC commented Apr 1, 2025

Would really like this to be updated to React 19, any plans for this?

@Envoy-VC Envoy-VC linked a pull request Apr 4, 2025 that will close this issue
2 tasks
@turkyden
Copy link

turkyden commented Apr 5, 2025

Would really like this to be updated to React 19, any plans for this?

awesome

@pierroo
Copy link

pierroo commented May 16, 2025

I see that the push request wasn't accepted; did you guys manage to get it to work with react 19?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants