Skip to content

Add an option to remove brakeman attributes in JUnit report #1926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pbernery opened this issue Mar 14, 2025 · 3 comments
Open

Add an option to remove brakeman attributes in JUnit report #1926

pbernery opened this issue Mar 14, 2025 · 3 comments

Comments

@pbernery
Copy link

Is your feature request related to a problem? Please describe.
I encounter the issue declared in #1763: the JUnit report is refused by CircleCI.

Describe the solution you'd like
While there is a workaround proposed in the issue above, I wonder if an option to remove brakeman specific attributes won't be better? Or even remove the specific attributes at all: are they used by anyone? Hard to know I guess, but the original PR that introduced the JUnit format was for CircleCI support, but CircleCI does not support these additional attributes anymore.

Describe alternatives you've considered

  • either add an option to remove those attributes,
  • or remove those attributes.

Additional context
Add any other context or screenshots about the feature request here.

@presidentbeef
Copy link
Owner

Kind of confused about why these were added in the first place if they weren't valid. Looking at the original PR, seems like the attributes were specific to CircleCI and never valid for plain JUnit.

So yes I'm supportive of dropping them entirely.

@pbernery
Copy link
Author

Alright. Then I will propose a PR to remove those attributes.
Thank you @presidentbeef.

@pbernery
Copy link
Author

Here is a PR with the proposed changes: #1934.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants