Skip to content

Commit bc805f9

Browse files
committed
feat: integrate events and update tests
Signed-off-by: Piaras <[email protected]>
1 parent d42c1d6 commit bc805f9

29 files changed

+245
-147
lines changed

pkg/api/authn_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -954,7 +954,7 @@ func TestCookiestoreCleanup(t *testing.T) {
954954
err = os.Chtimes(sessionPath, changeTime, changeTime)
955955
So(err, ShouldBeNil)
956956

957-
imgStore := local.NewImageStore(rootDir, false, false, log, metrics, nil, nil, nil)
957+
imgStore := local.NewImageStore(rootDir, false, false, log, metrics, nil, nil, nil, nil)
958958

959959
storeController := storage.StoreController{
960960
DefaultStore: imgStore,
@@ -989,7 +989,7 @@ func TestCookiestoreCleanup(t *testing.T) {
989989
err = os.WriteFile(sessionPath, []byte("session"), storageConstants.DefaultFilePerms)
990990
So(err, ShouldBeNil)
991991

992-
imgStore := local.NewImageStore(rootDir, false, false, log, metrics, nil, nil, nil)
992+
imgStore := local.NewImageStore(rootDir, false, false, log, metrics, nil, nil, nil, nil)
993993

994994
storeController := storage.StoreController{
995995
DefaultStore: imgStore,

pkg/api/config/config.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -512,6 +512,10 @@ func (c *Config) IsSyncEnabled() bool {
512512
return c.Extensions != nil && c.Extensions.Sync != nil && *c.Extensions.Sync.Enable
513513
}
514514

515+
func (c *Config) AreEventsEnabled() bool {
516+
return c.Extensions != nil && c.Extensions.Events != nil && *c.Extensions.Events.Enable
517+
}
518+
515519
func IsOpenIDSupported(provider string) bool {
516520
for _, supportedProvider := range openIDSupportedProviders {
517521
if supportedProvider == provider {

pkg/api/controller.go

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ import (
2323
"zotregistry.dev/zot/pkg/common"
2424
ext "zotregistry.dev/zot/pkg/extensions"
2525
extconf "zotregistry.dev/zot/pkg/extensions/config"
26+
"zotregistry.dev/zot/pkg/extensions/events"
2627
"zotregistry.dev/zot/pkg/extensions/monitoring"
2728
"zotregistry.dev/zot/pkg/log"
2829
"zotregistry.dev/zot/pkg/meta"
@@ -46,6 +47,7 @@ type Controller struct {
4647
Audit *log.Logger
4748
Server *http.Server
4849
Metrics monitoring.MetricServer
50+
EventRecorder events.Recorder
4951
CveScanner ext.CveScanner
5052
SyncOnDemand SyncOnDemand
5153
RelyingParties map[string]rp.RelyingParty
@@ -284,6 +286,12 @@ func (c *Controller) Init() error {
284286

285287
c.Metrics = monitoring.NewMetricsServer(enabled, c.Log)
286288

289+
eventRecorder, err := ext.NewEventRecorder(c.Config, c.Log)
290+
if err != nil {
291+
return err
292+
}
293+
c.EventRecorder = eventRecorder
294+
287295
if err := c.InitImageStore(); err != nil { //nolint:contextcheck
288296
return err
289297
}
@@ -314,7 +322,7 @@ func (c *Controller) InitCVEInfo() {
314322
func (c *Controller) InitImageStore() error {
315323
linter := ext.GetLinter(c.Config, c.Log)
316324

317-
storeController, err := storage.New(c.Config, linter, c.Metrics, c.Log)
325+
storeController, err := storage.New(c.Config, linter, c.Metrics, c.Log, c.EventRecorder)
318326
if err != nil {
319327
return err
320328
}

pkg/cli/client/cve_cmd_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@ func TestNegativeServerResponse(t *testing.T) {
119119
dir := t.TempDir()
120120

121121
imageStore := local.NewImageStore(dir, false, false,
122-
log.NewLogger("debug", ""), monitoring.NewMetricsServer(false, log.NewLogger("debug", "")), nil, nil, nil)
122+
log.NewLogger("debug", ""), monitoring.NewMetricsServer(false, log.NewLogger("debug", "")), nil, nil, nil, nil)
123123

124124
storeController := storage.StoreController{
125125
DefaultStore: imageStore,

pkg/extensions/extension_image_trust_test.go

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -214,7 +214,7 @@ func RunSignatureUploadAndVerificationTests(t *testing.T, cacheDriverParams map[
214214
logger.Logger = logger.Output(writers)
215215

216216
imageStore := local.NewImageStore(globalDir, false, false,
217-
logger, monitoring.NewMetricsServer(false, logger), nil, nil, nil)
217+
logger, monitoring.NewMetricsServer(false, logger), nil, nil, nil, nil)
218218

219219
storeController := storage.StoreController{
220220
DefaultStore: imageStore,
@@ -335,7 +335,7 @@ func RunSignatureUploadAndVerificationTests(t *testing.T, cacheDriverParams map[
335335
logger.Logger = logger.Output(writers)
336336

337337
imageStore := local.NewImageStore(globalDir, false, false,
338-
logger, monitoring.NewMetricsServer(false, logger), nil, nil, nil)
338+
logger, monitoring.NewMetricsServer(false, logger), nil, nil, nil, nil)
339339

340340
storeController := storage.StoreController{
341341
DefaultStore: imageStore,
@@ -443,7 +443,7 @@ func RunSignatureUploadAndVerificationTests(t *testing.T, cacheDriverParams map[
443443
logger.Logger = logger.Output(writers)
444444

445445
imageStore := local.NewImageStore(globalDir, false, false,
446-
logger, monitoring.NewMetricsServer(false, logger), nil, nil, nil)
446+
logger, monitoring.NewMetricsServer(false, logger), nil, nil, nil, nil)
447447

448448
storeController := storage.StoreController{
449449
DefaultStore: imageStore,
@@ -606,7 +606,7 @@ func RunSignatureUploadAndVerificationTests(t *testing.T, cacheDriverParams map[
606606
logger.Logger = logger.Output(writers)
607607

608608
imageStore := local.NewImageStore(globalDir, false, false,
609-
logger, monitoring.NewMetricsServer(false, logger), nil, nil, nil)
609+
logger, monitoring.NewMetricsServer(false, logger), nil, nil, nil, nil)
610610

611611
storeController := storage.StoreController{
612612
DefaultStore: imageStore,
@@ -870,7 +870,7 @@ func RunSignatureUploadAndVerificationTests(t *testing.T, cacheDriverParams map[
870870
logger.Logger = logger.Output(writers)
871871

872872
imageStore := local.NewImageStore(globalDir, false, false,
873-
logger, monitoring.NewMetricsServer(false, logger), nil, nil, nil)
873+
logger, monitoring.NewMetricsServer(false, logger), nil, nil, nil, nil)
874874

875875
storeController := storage.StoreController{
876876
DefaultStore: imageStore,

pkg/extensions/lint/lint_test.go

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -489,7 +489,7 @@ func TestVerifyMandatoryAnnotationsFunction(t *testing.T) {
489489

490490
linter := lint.NewLinter(lintConfig, log.NewLogger("debug", ""))
491491
imgStore := local.NewImageStore(dir, false, false,
492-
log.NewLogger("debug", ""), monitoring.NewMetricsServer(false, log.NewLogger("debug", "")), linter, nil, nil)
492+
log.NewLogger("debug", ""), monitoring.NewMetricsServer(false, log.NewLogger("debug", "")), linter, nil, nil, nil)
493493

494494
indexContent, err := imgStore.GetIndexContent("zot-test")
495495
So(err, ShouldBeNil)
@@ -521,7 +521,7 @@ func TestVerifyMandatoryAnnotationsFunction(t *testing.T) {
521521

522522
linter := lint.NewLinter(lintConfig, log.NewLogger("debug", ""))
523523
imgStore := local.NewImageStore(dir, false, false,
524-
log.NewLogger("debug", ""), monitoring.NewMetricsServer(false, log.NewLogger("debug", "")), linter, nil, nil)
524+
log.NewLogger("debug", ""), monitoring.NewMetricsServer(false, log.NewLogger("debug", "")), linter, nil, nil, nil)
525525

526526
indexContent, err := imgStore.GetIndexContent("zot-test")
527527
So(err, ShouldBeNil)
@@ -591,7 +591,7 @@ func TestVerifyMandatoryAnnotationsFunction(t *testing.T) {
591591

592592
linter := lint.NewLinter(lintConfig, log.NewLogger("debug", ""))
593593
imgStore := local.NewImageStore(dir, false, false,
594-
log.NewLogger("debug", ""), monitoring.NewMetricsServer(false, log.NewLogger("debug", "")), linter, nil, nil)
594+
log.NewLogger("debug", ""), monitoring.NewMetricsServer(false, log.NewLogger("debug", "")), linter, nil, nil, nil)
595595

596596
pass, err := linter.CheckMandatoryAnnotations("zot-test", digest, imgStore)
597597
So(err, ShouldBeNil)
@@ -653,7 +653,7 @@ func TestVerifyMandatoryAnnotationsFunction(t *testing.T) {
653653

654654
linter := lint.NewLinter(lintConfig, log.NewLogger("debug", ""))
655655
imgStore := local.NewImageStore(dir, false, false,
656-
log.NewLogger("debug", ""), monitoring.NewMetricsServer(false, log.NewLogger("debug", "")), linter, nil, nil)
656+
log.NewLogger("debug", ""), monitoring.NewMetricsServer(false, log.NewLogger("debug", "")), linter, nil, nil, nil)
657657

658658
pass, err := linter.CheckMandatoryAnnotations("zot-test", digest, imgStore)
659659
So(err, ShouldNotBeNil)
@@ -717,7 +717,7 @@ func TestVerifyMandatoryAnnotationsFunction(t *testing.T) {
717717

718718
linter := lint.NewLinter(lintConfig, log.NewLogger("debug", ""))
719719
imgStore := local.NewImageStore(dir, false, false,
720-
log.NewLogger("debug", ""), monitoring.NewMetricsServer(false, log.NewLogger("debug", "")), linter, nil, nil)
720+
log.NewLogger("debug", ""), monitoring.NewMetricsServer(false, log.NewLogger("debug", "")), linter, nil, nil, nil)
721721

722722
pass, err := linter.CheckMandatoryAnnotations("zot-test", digest, imgStore)
723723
So(err, ShouldBeNil)
@@ -780,7 +780,7 @@ func TestVerifyMandatoryAnnotationsFunction(t *testing.T) {
780780

781781
linter := lint.NewLinter(lintConfig, log.NewLogger("debug", ""))
782782
imgStore := local.NewImageStore(dir, false, false,
783-
log.NewLogger("debug", ""), monitoring.NewMetricsServer(false, log.NewLogger("debug", "")), linter, nil, nil)
783+
log.NewLogger("debug", ""), monitoring.NewMetricsServer(false, log.NewLogger("debug", "")), linter, nil, nil, nil)
784784

785785
err = os.Chmod(path.Join(dir, "zot-test", "blobs"), 0o000)
786786
if err != nil {
@@ -878,7 +878,7 @@ func TestVerifyMandatoryAnnotationsFunction(t *testing.T) {
878878

879879
linter := lint.NewLinter(lintConfig, log.NewLogger("debug", ""))
880880
imgStore := local.NewImageStore(dir, false, false,
881-
log.NewLogger("debug", ""), monitoring.NewMetricsServer(false, log.NewLogger("debug", "")), linter, nil, nil)
881+
log.NewLogger("debug", ""), monitoring.NewMetricsServer(false, log.NewLogger("debug", "")), linter, nil, nil, nil)
882882

883883
err = os.Chmod(path.Join(dir, "zot-test", "blobs", "sha256", manifest.Config.Digest.Encoded()), 0o000)
884884
if err != nil {

pkg/extensions/scrub/scrub_test.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -195,7 +195,7 @@ func TestRunScrubRepo(t *testing.T) {
195195
UseRelPaths: true,
196196
}, log)
197197
imgStore := local.NewImageStore(dir, true,
198-
true, log, metrics, nil, cacheDriver, nil)
198+
true, log, metrics, nil, cacheDriver, nil, nil)
199199

200200
srcStorageCtlr := ociutils.GetDefaultStoreController(dir, log)
201201
image := CreateDefaultVulnerableImage()
@@ -231,7 +231,7 @@ func TestRunScrubRepo(t *testing.T) {
231231
UseRelPaths: true,
232232
}, log)
233233
imgStore := local.NewImageStore(dir, true,
234-
true, log, metrics, nil, cacheDriver, nil)
234+
true, log, metrics, nil, cacheDriver, nil, nil)
235235

236236
srcStorageCtlr := ociutils.GetDefaultStoreController(dir, log)
237237
image := CreateDefaultVulnerableImage()
@@ -272,7 +272,7 @@ func TestRunScrubRepo(t *testing.T) {
272272
Name: "cache",
273273
UseRelPaths: true,
274274
}, log)
275-
imgStore := local.NewImageStore(dir, true, true, log, metrics, nil, cacheDriver, nil)
275+
imgStore := local.NewImageStore(dir, true, true, log, metrics, nil, cacheDriver, nil, nil)
276276

277277
srcStorageCtlr := ociutils.GetDefaultStoreController(dir, log)
278278
image := CreateDefaultVulnerableImage()

pkg/extensions/search/cve/cve_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -319,7 +319,7 @@ func TestImageFormat(t *testing.T) {
319319
dbDir := t.TempDir()
320320

321321
metrics := monitoring.NewMetricsServer(false, log)
322-
defaultStore := local.NewImageStore(imgDir, false, false, log, metrics, nil, nil, nil)
322+
defaultStore := local.NewImageStore(imgDir, false, false, log, metrics, nil, nil, nil, nil)
323323
storeController := storage.StoreController{DefaultStore: defaultStore}
324324

325325
params := boltdb.DBParameters{

pkg/extensions/search/cve/scan_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -505,7 +505,7 @@ func TestScanGeneratorWithRealData(t *testing.T) {
505505

506506
metrics := monitoring.NewMetricsServer(true, logger)
507507
imageStore := local.NewImageStore(rootDir, false, false,
508-
logger, metrics, nil, nil, nil)
508+
logger, metrics, nil, nil, nil, nil)
509509
storeController := storage.StoreController{DefaultStore: imageStore}
510510

511511
image := CreateRandomVulnerableImage()

pkg/extensions/search/cve/trivy/scanner_internal_test.go

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ import (
1616

1717
zerr "zotregistry.dev/zot/errors"
1818
"zotregistry.dev/zot/pkg/common"
19+
"zotregistry.dev/zot/pkg/extensions/events"
1920
"zotregistry.dev/zot/pkg/extensions/monitoring"
2021
cvecache "zotregistry.dev/zot/pkg/extensions/search/cve/cache"
2122
"zotregistry.dev/zot/pkg/extensions/search/cve/model"
@@ -51,14 +52,16 @@ func TestMultipleStoragePath(t *testing.T) {
5152

5253
log := log.NewLogger("debug", "")
5354
metrics := monitoring.NewMetricsServer(false, log)
55+
recorder, err := events.NewRecorder(events.LogSink(log), log)
56+
So(err, ShouldBeNil)
5457

5558
// Create ImageStore
5659

57-
firstStore := local.NewImageStore(firstRootDir, false, false, log, metrics, nil, nil, nil)
60+
firstStore := local.NewImageStore(firstRootDir, false, false, log, metrics, nil, nil, nil, recorder)
5861

59-
secondStore := local.NewImageStore(secondRootDir, false, false, log, metrics, nil, nil, nil)
62+
secondStore := local.NewImageStore(secondRootDir, false, false, log, metrics, nil, nil, nil, recorder)
6063

61-
thirdStore := local.NewImageStore(thirdRootDir, false, false, log, metrics, nil, nil, nil)
64+
thirdStore := local.NewImageStore(thirdRootDir, false, false, log, metrics, nil, nil, nil, recorder)
6265

6366
storeController := storage.StoreController{}
6467

@@ -172,7 +175,7 @@ func TestTrivyLibraryErrors(t *testing.T) {
172175
metrics := monitoring.NewMetricsServer(false, log)
173176

174177
// Create ImageStore
175-
store := local.NewImageStore(rootDir, false, false, log, metrics, nil, nil, nil)
178+
store := local.NewImageStore(rootDir, false, false, log, metrics, nil, nil, nil, nil)
176179

177180
storeController := storage.StoreController{}
178181
storeController.DefaultStore = store
@@ -313,7 +316,7 @@ func TestImageScannable(t *testing.T) {
313316
// Continue with initializing the objects the scanner depends on
314317
metrics := monitoring.NewMetricsServer(false, log)
315318

316-
store := local.NewImageStore(rootDir, false, false, log, metrics, nil, nil, nil)
319+
store := local.NewImageStore(rootDir, false, false, log, metrics, nil, nil, nil, nil)
317320

318321
storeController := storage.StoreController{}
319322
storeController.DefaultStore = store
@@ -367,7 +370,7 @@ func TestTrivyDBUrl(t *testing.T) {
367370
metrics := monitoring.NewMetricsServer(false, log)
368371

369372
// Create ImageStore
370-
store := local.NewImageStore(rootDir, false, false, log, metrics, nil, nil, nil)
373+
store := local.NewImageStore(rootDir, false, false, log, metrics, nil, nil, nil, nil)
371374

372375
storeController := storage.StoreController{}
373376
storeController.DefaultStore = store

pkg/extensions/search/cve/trivy/scanner_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -168,7 +168,7 @@ func TestVulnerableLayer(t *testing.T) {
168168

169169
log := log.NewLogger("debug", "")
170170
imageStore := local.NewImageStore(tempDir, false, false,
171-
log, monitoring.NewMetricsServer(false, log), nil, nil, nil)
171+
log, monitoring.NewMetricsServer(false, log), nil, nil, nil, nil)
172172

173173
storeController := storage.StoreController{
174174
DefaultStore: imageStore,
@@ -239,7 +239,7 @@ func TestVulnerableLayer(t *testing.T) {
239239

240240
log := log.NewLogger("debug", "")
241241
imageStore := local.NewImageStore(tempDir, false, false,
242-
log, monitoring.NewMetricsServer(false, log), nil, nil, nil)
242+
log, monitoring.NewMetricsServer(false, log), nil, nil, nil, nil)
243243

244244
storeController := storage.StoreController{
245245
DefaultStore: imageStore,

pkg/extensions/search/search_test.go

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1159,7 +1159,7 @@ func TestExpandedRepoInfo(t *testing.T) {
11591159
ctlr := api.NewController(conf)
11601160

11611161
imageStore := local.NewImageStore(tempDir, false, false,
1162-
log.NewLogger("debug", ""), monitoring.NewMetricsServer(false, log.NewLogger("debug", "")), nil, nil, nil)
1162+
log.NewLogger("debug", ""), monitoring.NewMetricsServer(false, log.NewLogger("debug", "")), nil, nil, nil, nil)
11631163

11641164
storeController := storage.StoreController{
11651165
DefaultStore: imageStore,
@@ -1281,7 +1281,7 @@ func TestExpandedRepoInfo(t *testing.T) {
12811281

12821282
log := log.NewLogger("debug", "")
12831283
metrics := monitoring.NewMetricsServer(false, log)
1284-
testStorage := local.NewImageStore(rootDir, false, false, log, metrics, nil, nil, nil)
1284+
testStorage := local.NewImageStore(rootDir, false, false, log, metrics, nil, nil, nil, nil)
12851285

12861286
resp, err := resty.R().Get(baseURL + "/v2/")
12871287
So(resp, ShouldNotBeNil)
@@ -1637,7 +1637,7 @@ func TestExpandedRepoInfo(t *testing.T) {
16371637
ctlr := api.NewController(conf)
16381638

16391639
imageStore := local.NewImageStore(conf.Storage.RootDirectory, false, false,
1640-
log.NewLogger("debug", ""), monitoring.NewMetricsServer(false, log.NewLogger("debug", "")), nil, nil, nil)
1640+
log.NewLogger("debug", ""), monitoring.NewMetricsServer(false, log.NewLogger("debug", "")), nil, nil, nil, nil)
16411641

16421642
storeController := storage.StoreController{
16431643
DefaultStore: imageStore,
@@ -1799,7 +1799,7 @@ func TestExpandedRepoInfo(t *testing.T) {
17991799

18001800
log := log.NewLogger("debug", "")
18011801
metrics := monitoring.NewMetricsServer(false, log)
1802-
testStorage := local.NewImageStore(rootDir, false, false, log, metrics, nil, nil, nil)
1802+
testStorage := local.NewImageStore(rootDir, false, false, log, metrics, nil, nil, nil, nil)
18031803

18041804
resp, err := resty.R().Get(baseURL + "/v2/")
18051805
So(resp, ShouldNotBeNil)
@@ -6054,7 +6054,7 @@ func TestMetaDBWhenDeletingImages(t *testing.T) {
60546054
// get signatur digest
60556055
log := log.NewLogger("debug", "")
60566056
metrics := monitoring.NewMetricsServer(false, log)
6057-
storage := local.NewImageStore(dir, false, false, log, metrics, nil, nil, nil)
6057+
storage := local.NewImageStore(dir, false, false, log, metrics, nil, nil, nil, nil)
60586058

60596059
indexBlob, err := storage.GetIndexContent(repo)
60606060
So(err, ShouldBeNil)
@@ -6128,7 +6128,7 @@ func TestMetaDBWhenDeletingImages(t *testing.T) {
61286128
// get signatur digest
61296129
log := log.NewLogger("debug", "")
61306130
metrics := monitoring.NewMetricsServer(false, log)
6131-
storage := local.NewImageStore(dir, false, false, log, metrics, nil, nil, nil)
6131+
storage := local.NewImageStore(dir, false, false, log, metrics, nil, nil, nil, nil)
61326132

61336133
indexBlob, err := storage.GetIndexContent(repo)
61346134
So(err, ShouldBeNil)

pkg/extensions/sync/destination.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -304,5 +304,5 @@ func getTempRootDirFromImageReference(imageReference types.ImageReference, repo,
304304
func getImageStore(rootDir string, log log.Logger) storageTypes.ImageStore {
305305
metrics := monitoring.NewMetricsServer(false, log)
306306

307-
return local.NewImageStore(rootDir, false, false, log, metrics, nil, nil, nil)
307+
return local.NewImageStore(rootDir, false, false, log, metrics, nil, nil, nil, nil)
308308
}

pkg/extensions/sync/sync_internal_test.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ func TestInjectSyncUtils(t *testing.T) {
7272

7373
log := log.Logger{Logger: zerolog.New(os.Stdout)}
7474
metrics := monitoring.NewMetricsServer(false, log)
75-
imageStore := local.NewImageStore(t.TempDir(), false, false, log, metrics, nil, nil, nil)
75+
imageStore := local.NewImageStore(t.TempDir(), false, false, log, metrics, nil, nil, nil, nil)
7676
injected = inject.InjectFailure(0)
7777

7878
ols := NewOciLayoutStorage(storage.StoreController{DefaultStore: imageStore})
@@ -216,7 +216,7 @@ func TestDestinationRegistry(t *testing.T) {
216216
UseRelPaths: true,
217217
}, log)
218218

219-
syncImgStore := local.NewImageStore(dir, true, true, log, metrics, nil, cacheDriver, nil)
219+
syncImgStore := local.NewImageStore(dir, true, true, log, metrics, nil, cacheDriver, nil, nil)
220220
repoName := "repo"
221221

222222
storeController := storage.StoreController{DefaultStore: syncImgStore}
@@ -334,7 +334,7 @@ func TestDestinationRegistry(t *testing.T) {
334334
MandatoryAnnotations: []string{"annot1"},
335335
}, log)
336336

337-
syncImgStore := local.NewImageStore(dir, true, true, log, metrics, linter, cacheDriver, nil)
337+
syncImgStore := local.NewImageStore(dir, true, true, log, metrics, linter, cacheDriver, nil, nil)
338338
repoName := "repo"
339339

340340
storeController := storage.StoreController{DefaultStore: syncImgStore}

pkg/meta/hooks_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ func TestOnUpdateManifest(t *testing.T) {
2626
storeController := storage.StoreController{}
2727
log := log.NewLogger("debug", "")
2828
metrics := monitoring.NewMetricsServer(false, log)
29-
storeController.DefaultStore = local.NewImageStore(rootDir, true, true, log, metrics, nil, nil, nil)
29+
storeController.DefaultStore = local.NewImageStore(rootDir, true, true, log, metrics, nil, nil, nil, nil)
3030

3131
params := boltdb.DBParameters{
3232
RootDir: rootDir,

0 commit comments

Comments
 (0)