Skip to content

v7.3.3 release is missing dist directory #2022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ggetz opened this issue Aug 22, 2024 · 3 comments · Fixed by #2023
Closed

v7.3.3 release is missing dist directory #2022

ggetz opened this issue Aug 22, 2024 · 3 comments · Fixed by #2023
Assignees
Labels

Comments

@ggetz
Copy link

ggetz commented Aug 22, 2024

protobuf.js version: 7.3.3 (also occurred in v7.3.1)

The latest release is missing the dist directory when installed via npm.

✘ [ERROR] Could not resolve "protobufjs/dist/minimal/protobuf.js"

    packages/engine/Source/Core/GoogleEarthEnterpriseMetadata.js:1:26:
      1 │ import * as protobuf from "protobufjs/dist/minimal/protobuf.js";
        ╵                           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Is this purposeful? If it is, we'll update to the new path. But it does not appear in the changelog, and the dist/ path is still listed in package.json under files.

See CesiumGS/cesium#12143

@danielbankhead
Copy link
Contributor

My mistake, I will resolve this shortly

@danielbankhead danielbankhead self-assigned this Aug 22, 2024
@ggetz
Copy link
Author

ggetz commented Aug 22, 2024

Thanks @danielbankhead!

@danielbankhead
Copy link
Contributor

Published! dist/ should be available now. Additionally, to prevent this from happening in the future I've improved our publish script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants