fix: always set isPr to true or false and never undefined

Author: pvdlg

lib/bitrise.js

@@ -13,7 +13,7 @@ module.exports = {
 			buildUrl: process.env.BITRISE_BUILD_URL,
 			branch: process.env.BITRISE_GIT_BRANCH,
 			pr: process.env.BITRISE_PULL_REQUEST === 'false' ? undefined : process.env.BITRISE_PULL_REQUEST,
-			isPr: process.env.BITRISE_PULL_REQUEST && process.env.BITRISE_PULL_REQUEST !== 'false',
+			isPr: Boolean(process.env.BITRISE_PULL_REQUEST && process.env.BITRISE_PULL_REQUEST !== 'false'),
 			slug: process.env.BITRISE_APP_SLUG,
 		};
 	},

lib/buildkite.js

@@ -14,7 +14,7 @@ module.exports = {
 			branch: process.env.BUILDKITE_BRANCH,
 			slug: `${process.env.BUILDKITE_ORGANIZATION_SLUG}/${process.env.BUILDKITE_PROJECT_SLUG}`,
 			pr: process.env.BUILDKITE_PULL_REQUEST === 'false' ? undefined : process.env.BUILDKITE_PULL_REQUEST,
-			isPr: process.env.BUILDKITE_PULL_REQUEST && process.env.BUILDKITE_PULL_REQUEST !== 'false',
+			isPr: Boolean(process.env.BUILDKITE_PULL_REQUEST && process.env.BUILDKITE_PULL_REQUEST !== 'false'),
 			root: process.env.BUILDKITE_BUILD_CHECKOUT_PATH,
 		};
 	},

lib/semaphore.js

@@ -14,7 +14,7 @@ module.exports = {
 			build: process.env.SEMAPHORE_BUILD_NUMBER,
 			branch: process.env.BRANCH_NAME,
 			pr: process.env.PULL_REQUEST_NUMBER,
-			isPr: Boolean(process.env.PULL_REQUEST_NUMBER),
+			isPr: Boolean(process.env.PULL_REQUEST_NUMBER && process.env.PULL_REQUEST_NUMBER !== 'false'),
 			slug: process.env.SEMAPHORE_REPO_SLUG,
 			root: process.env.SEMAPHORE_PROJECT_DIR,
 		};

lib/shippable.js

@@ -14,7 +14,7 @@ module.exports = {
 			branch: process.env.BASE_BRANCH || process.env.BRANCH,
 			job: process.env.JOB_NUMBER,
 			pr: process.env.PULL_REQUEST === 'false' ? undefined : process.env.PULL_REQUEST,
-			isPr: process.env.IS_PULL_REQUEST && process.env.IS_PULL_REQUEST === 'true',
+			isPr: Boolean(process.env.IS_PULL_REQUEST && process.env.IS_PULL_REQUEST === 'true'),
 			slug: process.env.SHIPPABLE_REPO_SLUG,
 			root: process.env.SHIPPABLE_BUILD_DIR,
 		};

lib/travis.js

@@ -13,7 +13,7 @@ module.exports = {
 			branch: process.env.TRAVIS_BRANCH,
 			job: process.env.TRAVIS_JOB_NUMBER,
 			pr: process.env.TRAVIS_PULL_REQUEST === 'false' ? undefined : process.env.TRAVIS_PULL_REQUEST,
-			isPr: process.env.TRAVIS_PULL_REQUEST && process.env.TRAVIS_PULL_REQUEST !== 'false',
+			isPr: Boolean(process.env.TRAVIS_PULL_REQUEST && process.env.TRAVIS_PULL_REQUEST !== 'false'),
 			slug: process.env.TRAVIS_REPO_SLUG,
 			root: process.env.TRAVIS_BUILD_DIR,
 		};