Skip to content

rename _types to be public #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
samuelcolvin opened this issue Sep 13, 2022 · 4 comments · Fixed by #240
Closed

rename _types to be public #239

samuelcolvin opened this issue Sep 13, 2022 · 4 comments · Fixed by #240
Labels
good first issue Good for newcomers

Comments

@samuelcolvin
Copy link
Member

To something like schema_types, so types can be imported and used directly.
@samuelcolvin samuelcolvin added the good first issue Good for newcomers label Sep 13, 2022
@ighmaZ
Copy link

ighmaZ commented Sep 13, 2022

Hi @samuelcolvin ! what should be done here?

@samuelcolvin
Copy link
Member Author

The _types.py file needs to be renamed, and associated changes.

@ighmaZ
Copy link

ighmaZ commented Sep 13, 2022

@samuelcolvin so _types.py should be changed to schema_types.py everywhere . right?

@samuelcolvin
Copy link
Member Author

Yes exactly.

@MatthijsKok MatthijsKok mentioned this issue Sep 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rename _types to be public MatthijsKok/pydantic-core
2 participants
@samuelcolvin @ighmaZ